React-native-navigation: dismissAllModals promise needs to include closing animation time.

Created on 5 Oct 2019  ·  5Comments  ·  Source: wix/react-native-navigation

Issue Description

The event of closing modal is finished (promise resolved), but the closing animation is still in progress. Consequently, the second modal is actually rendered (with componentDidMount and stuff), but the view is invisible.

Related to #3733 and #5045

Steps to Reproduce / Code Snippets / Screenshots

// this won't work
await Navigation.dismissAllModals();
await Navigation.showModal(); // component is rendered, but invisible

// this works
await Navigation.dismissAllModals();
await wait(1000); // 1 sec
await Navigation.showModal(); // component is rendered, and visible

Environment

  • React Native Navigation version: 3.1.2
  • React Native version: 0.60.5
  • Platform(s) (iOS, Android, or both?): iOS
  • Device info (Simulator/Device? OS version? Debug/Release?): iOS 13
iOS acceptebug 📌 pinned

Most helpful comment

I believe this issue is still valid.

All 5 comments

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

This is definitely still an issue.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

I believe this issue is still valid.

Fixed by #6671

Was this page helpful?
0 / 5 - 0 ratings