React-native-navigation: [V3] mergeOptions does not change bottomTab colors

Created on 1 Aug 2019  路  1Comment  路  Source: wix/react-native-navigation

Issue Description

When I want to change the color of the bottomTab items, I call mergeOptions to change it accordingly. This works perfectly on iOS, but this feature doesn't seem to be implemented. (as BottomTabsController.java mergeOptions doesn't call tabPresenter.mergeOptions(options);)

Steps to Reproduce / Code Snippets / Screenshots

Navigation.setRoot({
    root: {
        bottomTabs: {
            id: 'root',
            children: [
                {
                    stack: {
                        id: `tab-1`,
                        children: [
                            {
                                component: {
                                    name: '1',
                                },
                            },
                        ],
                        options: {
                            bottomTab: {
                                iconColor: '#FFF',
                                textColor: '#FFF',
                            },
                            bottomTabs: {
                                animate: true,
                            },
                        },
                    },
                },
            ],
        },
    },
});

// some time later

Navigation.mergeOptions('root', {
    bottomTab: {
        iconColor: '#000',
        textColor: '#000',
    },
    bottomTabs: {
        animate: true,
    },
});
Navigation.mergeOptions(`tab-1`, {
    bottomTab: {
        iconColor: '#000',
        textColor: '#000',
    },
    bottomTabs: {
        animate: true,
    },
});

When mergeOptions is called, the items are changed accordingly on iOS, but not on android.

Environment

  • React Native Navigation version: 3.0.0-alpha.8
  • React Native version: 0.60.4
  • Platform(s) (iOS, Android, or both?): Android
  • Device info (Simulator/Device? OS version? Debug/Release?): All
Android acceptebug

Most helpful comment

Awesome, thanks for looking into this! @guyca

>All comments

Awesome, thanks for looking into this! @guyca

Was this page helpful?
0 / 5 - 0 ratings