React-native-navigation: [v2] Large title animation flicks with pull-to-refresh

Created on 24 May 2019  路  14Comments  路  Source: wix/react-native-navigation

Related to https://github.com/wix/react-native-navigation/issues/3538 posted in Jul 11, 2018 that is being ignored.

Large title doesn't behavior as expected when you have pull to refresh on the screen. I don't know if this is an iOS or react-native-navigation bug.

With small title:

small title

With large title:

large title bug


Environment

  • React Native Navigation version: 2.18.4
  • React Native version: 0.59
  • Platform(s) (iOS, Android, or both?): iOS
iOS acceptebug 馃搶 pinned

Most helpful comment

Still not stale

All 14 comments

Does still occur on react native 0.59 and react navigation 2.18.4

I think issue not in RNN, but in RCTScrollView,
There is a method setCustomRefreshControll in RCTScrollView
after change

[self addSubview:_customRefreshControl];
to
self.refreshControl = customRefreshControl;

flicks is gone, but pull to refresh show only once(( other offset etc logic failed after change

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

Not stale.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

Still not stale.

Still not stale, really sad as we can't use large title with pull down refresh (90% of the lists have that)

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

The issue has been closed for inactivity.

Still not stale

not stale

As part of an effort by @yogevbd to address all large title issues, he opened a PR with a fix to react-native. Hopefully it will be merged soon 馃檹

Looks like it's been merged now right? Nice one! https://github.com/facebook/react-native/pull/28236 Thanks for all the efforts to get it fixed, what else needs to happen for this to work in RNN?

This has been fixed by @yogevbd 's PR to react native, closing as there's nothing else to do in RNN.

Was this page helpful?
0 / 5 - 0 ratings