React-native-navigation: [V2][iOS] topBar.title.fontFamily reset on mergeOptions

Created on 29 Oct 2018 · 15Comments · Source: wix/react-native-navigation

Issue Description

topBar.title.fontFamily is being reset with mergeOptions

Steps to Reproduce / Code Snippets / Screenshots

Have a topBar.title.fontFamily set in defaultOptions and try to dynamically adjust the topBar by using mergeOptions. The fontFamily set in the defaultOptions will not be used.

Environment

Originally reported React Native Navigation version: 2.0.2628
Also tested on React Native Navigation version: 2.1.2
React Native version: 0.56
Platform(s) (iOS, Android, or both?): iOS

iOS acceptebug 🏚 stale

Source

Jazqa

👍2

All 15 comments

I have the problem that I can't set the fontFamily at all - it's just ignored. Is this the same bug?

Navigation.setRoot({
    root: {
      sideMenu: {
        id: 'sideMenu',
        left: {
          component: {
            id: MENU_SIDE,
            name: MENU_SIDE,
          },
        },
        center: {
          stack: {
            children: [
              {
                component: {
                  name: SCREEN_DASHBOARD,
                  options: {
                    topBar: {
                      noBorder: true,
                      visible: true,
                      title: {
                        text: 'Dashboard',
                        fontSize: 16,
                        color: '#171F24',
                        fontFamily: 'Roboto',
                      },
                      subtitle: {
                        text: 'Dashboard',
                        fontSize: 13,
                        color: '#171F24',
                        fontFamily: 'Roboto',
                      },
                    },
                  },
                },
              },
            ],
          },
        },
      },
    },
  });

fontSize and color are working as expected - but not fontFamily.
And everything is working for subtitle.

🤔

pkyeck on 9 Nov 2018

I have it set in Navigation.setDefaultOptions()

Jazqa on 9 Nov 2018

see #4188

pkyeck on 9 Nov 2018

That's unrelated in my case, since I am not using a subtitle

Jazqa on 9 Nov 2018

yep, but as I said in the comment in 4188, for me it was not related to using a subtitle - happened also when just trying to overwrite the fontFamily for title ...

pkyeck on 9 Nov 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

stale[bot] on 9 Dec 2018

this is still a problem afaik

pkyeck on 10 Dec 2018

I'm having the same issue with react-native-navigation 2.2.5.

It seems that Navigation.mergeOptions() does not perform a deep merge, as simple as that.

zabojad on 22 Dec 2018

👍1

@zabojad Looks to be true, seems to be doing a lodash deepClone, but anything deeper than one level like topbar: { background: { color: '#fff' } }
doesnt work, any solution to this ?

tyrong on 23 Dec 2018

👍1

@tyrong I don't have any solution yet.

In my case, I was trying to change the topbar title text after the screen shows up with a hidden topbar (visible: false option).

So I was doing:

Navigation.mergeOptions(props.componentId,{ topBar: { visible: true, title: { text: "blablabla..." }}});

and was loosing all my topBar default options.

I tried to workaround this problem by reseting at the same time all default options. It almost worked except for the alignment: 'center' option (Android) that I'm still loosing in that case...

The deep merge is perhaps one thing but it might not be the only issue with mergeOptions for topBar...

zabojad on 23 Dec 2018

@guyca I'm having that on Android (I see you've tagged this issue as an iOS one).

zabojad on 23 Dec 2018

stale[bot] on 24 Jan 2019

👎3

The issue has been closed for inactivity.

stale[bot] on 1 Feb 2019

This is not stale. I can still reproduce.