React-native-navigation: Bottom tabs are broken at 2.0.2563 version

Created on 27 Sep 2018  路  8Comments  路  Source: wix/react-native-navigation

Issue Description

On version 2.0.2562 my bottom bar looks like this:
image

After updating to 2.0.2563 or later the bottom bar looks like this:
image

Also what I noticed that if I click the tab they are invisible and after the click they appear again
image

So what happened on version 2.0.2563 so that some bottom tabs are invisible? 馃
Here is the comparison between those tags https://github.com/wix/react-native-navigation/compare/2.0.2562...2.0.2563


Environment

  • React Native Navigation version: 2.0.2563
  • React Native version: 0.54.4
  • Platform(s) (iOS, Android, or both?): iOS
  • Device info (Simulator/Device? OS version? Debug/Release?): Simulator
iOS v2

Most helpful comment

I have now tried version 2.0.2568 and the bug is gone! Good job 馃憤

All 8 comments

@yogevbd Hmm I guess something that you refactored in this commit made this broke 馃

Because between those tags @guyca didn't touch any iOS files :D

It should be fix in the latest version.. can you please check?

Just tried with version 2.0.2567 and it has the same problem :(

Can you post here your root layout structure? thanks

Very simple. It looks like this

Navigation.setRoot({
  root: {
    bottomTabs: {
      children: [
        {
          component: {
            name: Screen.Home,
            options: {
              bottomTab: {
                text: 'something',
                icon: require('./images/icon.png'),
                testID: 'something',
                selectedIconColor: someColor,
                selectedTextColor: someColor,
              },
            },
          },
        },
        {
          component: {
            name: Screen.Profile,
            options: {
              bottomTab: {
                text: 'something',
                icon: require('./images/icon.png'),
                testID: 'something',
                selectedIconColor: someColor,
                selectedTextColor: someColor,
              },
            },
          },
        },
        {
          component: {
            name: Screen.Store,
            options: {
              bottomTab: {
                text: 'something',
                icon: require('./images/icon.png'),
                testID: 'something',
                selectedIconColor: someColor,
                selectedTextColor: someColor,
              },
            },
          },
        },
        {
          stack: {
            children: [
              {
                component: {
                  name: Screen.Messages,
                  options: {
                    bottomTab: {
                      text: 'something',
                      icon: require('./images/icon.png'),
                      testID: 'something',
                      selectedIconColor: someColor,
                      selectedTextColor: someColor,
                    },
                  },
                },
              },
            ],
          },
        },
      ],
    },
  },
});

Will be fixed in the next release! thanks

I can try the new version tomorrow. Would be nice to keep issues open until they are tested :D

I have now tried version 2.0.2568 and the bug is gone! Good job 馃憤

Was this page helpful?
0 / 5 - 0 ratings