React-native-navigation: [v2] bottomTabs root configuration not respecting bottomTab text for stacks

[zachrnolan]

Issue Description

When using a stack within bottomTabs, the bottomTab text field is not respected. Here is my root configuration:

import { Navigation } from 'react-native-navigation'
import { registerScreens } from './src/screens'

registerScreens()

Navigation.events().registerAppLaunchedListener(() => {
  Navigation.setRoot({
    root: {
      bottomTabs: {
        children: [
          {
            stack: {
              children: [
                {
                  component: {
                    name: 'Home'
                  }
                }
              ],
              options: {
                topBar: {
                  title: {
                    text: 'Home'
                  }
                },
                bottomTab: {
                  text: 'Tab 1'
                }
              }
            }
          },
          {
            component: {
              name: 'Profile',
              options: {
                bottomTab: {
                  text: 'Tab 2'
                }
              }
            }
          }
        ],
        options: {}
      }
    }
  })
})

If I change this to only components, it works fine:

import { Navigation } from 'react-native-navigation'
import { registerScreens } from './src/screens'

registerScreens()

Navigation.events().registerAppLaunchedListener(() => {
  Navigation.setRoot({
    root: {
      bottomTabs: {
        children: [
          {
            component: {
              name: 'Home',
              options: {
                bottomTab: {
                  text: 'Tab 1'
                }
              }
            }
          },
          {
            component: {
              name: 'Profile',
              options: {
                bottomTab: {
                  text: 'Tab 2'
                }
              }
            }
          }
        ],
        options: {}
      }
    }
  })
})

Steps to Reproduce / Code Snippets / Screenshots

Screenshot with stack:

Screenshot with only components:

---

Environment

• React Native Navigation version: 2.0.2411
• React Native version: 0.56.0
• Platform(s) (iOS, Android, or both?): iOS (haven't tested this on Android yet)
• Device info (Simulator/Device? OS version? Debug/Release?): Simulator/Debug

[TimurAsayonok]

Yes, I have same with 2.0.2453.

And main problem, than when we use stack: we can see topBar and do what we want with tap bar. But when we don't use stack: we can't work with topBar

But, I found than when I add Icon for bottomTab I will get Icon and text for tab, @zachrnolan could you try this code:

Navigation.events().registerAppLaunchedListener(() => {
  Navigation.setRoot({
    root: {
      bottomTabs: {
        children: [
          {
            stack: {
              children: [
                {
                  component: {
                    name: 'Home'
                  }
                }
              ],
              options: {
                topBar: {
                  title: {
                    text: 'Home'
                  }
                },
                bottomTab: {
                  **icon: 'your ex. icon'**
                  text: 'Tab 1'
                }
              }
            }
          }
         }
        ],
        options: {}
      }
    }
  })
})

[lindesvard]

Having exact same problem, bottomTab text not displaying while inside a stack.

[JoelFieldCode]

@lindesvard do you have a logo set for the bottomTab? I was having this issue until I put a logo in. Silly fix I know but it has seemed to work for me.

[TimurAsayonok]

@JoelFieldCode Why sis you say 'Silly fix..' ?) How many applications do you know without Icons on the bottomTabs?)

[lindesvard]

@JoelFieldCode no, just played around a bit to see if it was ready or not. Everything worked fine except this issue. Maybe should try add icon also...

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

[stale[bot]]

The issue has been closed for inactivity.