React-native-navigation: [v2] Global Animation Settings from SetDefaultOptions

[thame]

Issue Description

Setting global animation settings do not work, settings are only animated from "Push" or "Pop" events.

Steps to Reproduce / Code Snippets / Screenshots

Defining animation settings in SetDefaultOptions doesn't work, using the same code in a "Push" event does.

      animations: {
        push: {
          content: {
            y: {
              from: 1000, to: 0,
            }
          }
        }
      },

---

Environment

• React Native Navigation version: 2.0.2397
• React Native version: 0.51.0
• Platform(s) (iOS, Android, or both?): Only tested on iOS
• Device info (Simulator/Device? OS version? Debug/Release?): iPhone 8 Device, iOS 11.4

[Lube]

Same happening for me on Android!

[guyca]

@Lube which RNN version do you have?

[lecoqjacob]

animating the topBar seems to be broken as well for any functionality

[mths0x5f]

Indeeed, I couldn't set default animations at all for iOS. And I can confirm setting default animations for Android is only working for "push".

As already reported, settings animations in a screen-basis is working.

EDIT: I'll edit this comment several times while I discover the fixes

For Android pop event take account default options, this line should be: Options resolvedOptions = resolveCurrentOptions(presenter.getDefaultOptions());
https://github.com/wix/react-native-navigation/blob/2c54caa073276f7325cb396cd001a6fcc9ccadde/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/stack/StackController.java#L195

I'm using 2.0.2422 version, @guyca / @yogevbd

[clytras]

I can confirm @mths0x5f fix https://github.com/wix/react-native-navigation/issues/3500#issuecomment-408696714 is working.

Any chance to have a PR? Is this on some king of a schedule?

[stefanc96]

Why on ios transition animations between screens doesn't work? On android works perfectly

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

[stale[bot]]

The issue has been closed for inactivity.