This repository could use some help I guess. At the time of writing, there's 762 open issues and 53 open pull requests. I'm not a reference when it comes to native iOS / Android code, but I could help closing questions that should be on Stack Overflow, duplicates and such to reduce the noise. It also seems there's many PR that address open issues, which would be good to merge and release as it leads to people forking (1550+) and maintaining their own fork.
Thoughts? @lelandrichardson @spikebrehm
Raise your hand if you feel like helping in that direction too! ✋
So, no response even after 5days 😟
+1
Thanks for today's release @christopherdro! Any feedback on how we could help bringing this repository up to speed?
For what it’s worth they haven’t been answering me either since August.
Best way to move forward is to move this repo to react-community and add new contributors or have it forked by some other organization that can allocate resources to keep it up to date.
In the meantime feel free to triage some of the tickets and ping me directly on ones that can be closed.
Go @christopherdro Go!
Duplicate of https://github.com/airbnb/react-native-maps/issues/1280 😆
We use this lib in a production app but will probably be leaving for Mapbox in the near future. They seem to be much more passionate about and committed to their SDK.
@wbattel4607 your unlikely to get better support from mapbox on react native. We already use them and they still consider the repo a beta. I’ve opened issues similar to this and was not answered kindly by the mapbox team. i think it’s going to be up to the community to build a proper map solution for react.
@digitaldavenyc what their repo has that this one does not is consistent updates. They have active developers working to bring it past beta.
@christopherdro thanks for your valuable input!
No problem. I try to help when I can but we could use more contributors. I reached out to team again and will wait for their response.
@christopherdro awesome! :tada: I'll take some time after work hours today to review open issues and invite people with questions to post on StackOverflow instead. I'll also go on StackOverflow and try to answer as much react-native-maps
questions as possible to give it a good dynamic.
@kytwb thanks for raising this important issue!
After briefly checking with a few of the other Airbnb contributors, It seems we're in favor of moving this over to react-community. I can help with that transition. If you or anyone else can add me to that organization on Github, I can transfer it over.
Please let me know if you need anything else and thank you again!
@felipecsl , I think @lelandrichardson has access to add you.
@brentvatne @dikaiosune @ide @jimmylee @skevy can any of you grant me permissions on react-community
to transfer this repo, please?
It's done, thanks @lelandrichardson !
Quick questions since this landed in react-community but I'm not familiar with the project's history:
Oh, one other follow-up: was CI running for this project before? If so, do I need to enable some service to make that happen under the new org?
@dikaiosune I'm a recent contributor, but I use the library for production and I am willing to participate in reviewing issues and PRs. I hope I won't be alone, as I don't have enough time to review all open issues in short time, but anyway I can help, if I'm given collaborator rights.
@alvelig @dikaiosune I'm also happy to help, unfortunately I can't help much with the iOS part of the codebase. I can help with the JS part and community-related (reviewing issues, support on StackOverflow when at reach, etc).
@dikaiosune
I'm not 100% sure how releases were managed in the past but recently I tried my best to resolve issues related to core RN changes and keep releases somewhat consistent. Probably best to lay a plan moving forward.
I don't think the CI does much right now outside a simple lint check.
The example project likely needs to be redone and would be great to make that part of the build process.
@christopherdro @lelandrichardson how can I help (no native knowledge here, but I can help with testing, PRs etc)?
Also (without trying to hijack the thread) this is something very important imho: #1862
Thank you.
@alvelig That'd be great! I don't have permissions to add collaborators but you can try pinging me or any other contributor for issues that you think can be closed or PR's that you've reviewed.
@rborn I agree that getting the installation instructions and example project up to date is very important and would help the frustration a lot of users are probably expressing on the open issues.
Maybe we can get a few people to help out with that?
@christopherdro could we ping somebody from airbnb to help us with that in the initial step? I mean there is a lot of knowledge to be passed the the new maintainers and this is for sure one of them.
@rborn I wrote you in your issue. Let's handle it, but you lead. This repo is as is. Nobody will help us. All the knowledge is in the repo. I'll help, but you are to be the QA. So you should show us the way to reproduce problems, then we will be able to find solutions and document it.
@christopherdro We need to apply strict rules at least initially to work out 700+ issues. We can't maintain it as now. There should be strict rules to be able to reproduce the problem to be able to help. I made a clear example repo without dependencies nor pods or google maps: https://github.com/alvelig/react-native-maps-example That could be a good start to fork and reproduce issues.
I'm trying to help, but that's frustrating to working it to no avail without restrictions, you know.
@christopherdro I made you an admin on this repository since you're the person volunteering here who was a collaborator before the repo's ownership change. Hopefully you all are able to figure out a good plan for maintaining this important library!
Great news @dikaiosune! Thanks!
My suggestion to the plan:
@dikaiosune Thanks. I'll try my best to kick things off.
@christopherdro let's elaborate an issue template. We need at least to checkout a example to reproduce the problem. Otherwise mark it as an enhancement or question.
We did a 1/8 of issues. Good job so far.
But still we lack QA. @rborn @kytwb you were willing to help. Other guys, step forward. We need QA to confirm user issues. Thanks in advance.
@alvelig @christopherdro we could "steal" this one 😇 once we finish the installation manual (which should be pretty soon)
https://github.com/facebook/react-native/blob/master/.github/ISSUE_TEMPLATE.md
@christopherdro I can take care of the issue template part, and thanks for the invite 🤗
I'd like to do what I can to help out as well. Possibly issue triage?
@calvinmikael yes please. Mention me or @rborn if you have an idea of solution or see an open issue that should be closed.
Less than 300 issues left...
If we reach 100 threshold it will be a manageable repo LOL
Tell me smb please that it was not in vane...
@alvelig that's amazing 🤗
I would like to contribute as well. Do you guys want to share facebook or slack or something ?
@rborn , @alvelig, and @christopherdro I will like to collaborate as well if the window is not closed. :+1:
@anp, it there any way @alvelig or me could get the right to push on npm ? @christopherdro seems really busy lately so the npm version is not in sync with what's in the repo.
It would also work if we could ping somebody else to do it, just let us know who 🤗
Hey everyone. Sorry for the late response.
If someone could prepare a PR with the version bump and changelog updates I'll merge and release a new version to npm.
Please reference a previous version bump to see all changes that are required.
https://github.com/react-community/react-native-maps/commit/c45131096fda44383335099bee80c2cd2136c231#diff-4ac32a78649ca5bdd8e0ba38b7006a1e
Here is the list of commits added since the last release.
https://github.com/react-community/react-native-maps/compare/v0.19.0...master
The changelog doesn't necessarily have to include every single commit. I tend to exclude doc/examples updates.
@christopherdro I'll try to do it today/tomorrow, thanks 🤗
@rborn I don't believe I have publish perms on npm, @lelandrichardson or someone from Airbnb would probably need to hand those out.
@rborn I should have some time today to get this done if you haven't started already.
I'll only be able to do it in 4h or so
Sent from my iPhone
On 9 Feb 2018, at 10:24, Christopher Dro notifications@github.com wrote:
@rborn I should have some time today to get this done if you haven't started already.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
No worries. I already started. Should be done shortly.
@rborn @christopherdro @alvelig I would like to contribute as well.
I am heavily using this library on my company apps. I implemented a new experimental provider using osmdroid (https://github.com/osmdroid/osmdroid) and got used to this lib android native codebase.
this library have huge adaption yet it's stuck somehow and issues are not getting closed nor pull requests are getting merged.
We're using it at our company too and I'm comfortable working on the 3 platforms (react, iOS and Android) what would it take to get it back up to speed?
@salah-ghanim We could use some help reviewing/testing PR's and organizing releases. I can add you add as a contributor if you're up for it.
@christopherdro I would love to do that, please do. there are lots of open pull requests and issues I can get started with :)
There's a lot of issues! In order to get this back on track I think we need to do couple of things:
Do we have any current active maintainers who could look into this and suggest what can be done?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
See updated issue. https://github.com/react-native-maps/react-native-maps/issues/3564
Most helpful comment
Less than 300 issues left...
If we reach 100 threshold it will be a manageable repo LOL
Tell me smb please that it was not in vane...