React-native-keychain: keychain + sharedpreferences support

[geirman]

wondering if you plan to also include SharedPreferences support for Android. A single component that abstracts both would be awesome.

[oblador]

It's definitely planned, but no ETA right now. A PR would be highly appreciated!

On Sat, Oct 10, 2015 at 10:59 AM, Chris Geirman [email protected]
wrote:

wondering if you plan to also include SharedPreferences support for Android. A single component that abstracts both would be awesome.

Reply to this email directly or view it on GitHub:
https://github.com/oblador/react-native-keychain/issues/12

[chrisvariety]

I think Keystore would be more appropriate? http://developer.android.com/training/articles/keystore.html

SharedPreferences isn't encrypted.

[corymsmith]

Was having a look at this the other day, may do an implementation with https://facebook.github.io/conceal/ and ship a PR over.

[geirman]

That looks pretty awesome, @corymsmith

[corymsmith]

@geirman I'll probably start digging into this today :)

[oblador]

@corymsmith :clap: :bow:

[corymsmith]

Ran into some conflicts with React Native so had to update Conceal to fix it.

https://github.com/facebook/conceal/pull/105

Made some great progress today! It looks like there are some issues with Conceal on recent Android versions that are in progress so will have to see how that progresses.!

[liorsaar1]

@corymsmith are you creating an android version for this ? would like to collaborate - [email protected]

[corymsmith]

@liorsaar1 Yes, I have some updates in the android-support branch of my fork. I was having some issues unencrypting and still working through the best approach for Android. I broke my arm so can't do much until thats all sorted unfortunately

[oblador]

@corymsmith: :clap: so excited about this! Get well :mask:

[paulondc]

Any updates about the android support ? I'm very excited about it :)

[corymsmith]

@paulondc I've been super busy as of late with a few other open source projects and my new consulting company so haven't looked at this in a it but it was super close when I last left off. I'll be needing this in a few apps in the near future so hoping to pick it back up and wrap a release in the next few weeks or less

[paulondc]

Thanks @corymsmith for all effort you are putting on this :clap:

I wonder if we could help you somehow, since this is going to introduce the initial support for android, I think we could have a special branch under this repository for this feature, so everybody interested on this could try it, watch the progress, create pull requests, etc..

What do you guys think about it ?

[corymsmith]

@paolondc The branch is here:

https://github.com/corymsmith/react-native-keychain/tree/android-support

[vonovak]

nice work! @paulondc when can we expect the android support in npm? Thanks!

[oblador]

Finally 0.3.0 with android support is on npm. Thanks to everyone involved making this happen!

[rops]

Hi folks, I was just wondering if there was any particular (security or performance) reason why Android's KeyStore wasn't used

[vonovak]

Hello,
Someone started the android implementation a while ago and used the
Facebook conceal in it. It was, however, incomplete and wasn't merged. I
picked it up and finished it. Not sure what the initial reasons were but
IMHO there is no big difference. With conceal you get support in <= 4.3 and
perhaps greater flexibility in what you can save.
On Jun 20, 2016 19:07, "Daniele Rossetti" [email protected] wrote:

Hi folks, I was just wondering if there was any particular (security or
performance) reason why Android's KeyStore wasn't used

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/oblador/react-native-keychain/issues/12#issuecomment-227205293,
or mute the thread
https://github.com/notifications/unsubscribe/ABfmw3qMh_PueXk-s3eEikI9XvBtMFWHks5qNsizgaJpZM4GMlNV
.