React-native-interactable: Maintenance

Created on 4 Apr 2018  路  8Comments  路  Source: wix/react-native-interactable

After merging #198, let's continue with maintenance:

  1. remove postinstall script (we don't need it anymore) and bump minor version, this solves #144, #140, #129, #194, #172.
  2. Add CI with Travis, build project on both platforms and run sanity with Detox on release builds. It will be perfect if we can run iOS on macOS and Android on Linux, but Travis does not support x86 emulators, so we can at least compile the Android version without running it :( (boo to you TravisCI)
  3. Add badges to README.md
enhancement

Most helpful comment

@rotemmiz @ButtersHub possible to move this to react-community or react-native-community? AirBNB moved their react-native-maps repo to the former a few months ago after they decided to change their approach with RN resources.

All 8 comments

Hi @rotemmiz ,
just a ping. Current status:

  • #198 npmignore is updated
  • #196 moved the behaviour to be identical on Android and iOS without crash
  1. PR based on #198 can be already made after merge: https://github.com/mkuczera/react-native-interactable/tree/remove-postinstall
  2. Currently setting up the travis checks. Tryout branch with the postInstall change already successfully builded. Also implement basic test for the travis build based on the #196 problem.

Hey @rotemmiz , what麓s the current status? Without any right, i can麓t cleanup the issues and the different tasks and need to ping you :(

Greetings
Michael

Hey @mkuczera,

Sorry for not being responsive enough.
We really appreciate all that maintenance work and I believe we will be able to soon find a solution as to how we streamline things in this repo, including adding rights to external contributors like yourself.
In the meantime, I'll keep watching PRs alongside @Buttershub.
I'll review those PRs you mentioned above.

Hey @rotemmiz, Hey @ButtersHub ,
i wanted to ask if there is any update? The issues are stacking up and would be easy to fix, but due to the process i have to wait right now. I know that you guys are busy, but i would appreciate any update to the current status.

Greetings
Michael

Hey @mkuczera, the ball is in your hands. We're ready when you are

@rotemmiz @ButtersHub possible to move this to react-community or react-native-community? AirBNB moved their react-native-maps repo to the former a few months ago after they decided to change their approach with RN resources.

The postinstall issue is fixed in #211. Would be nice to get it merged and stop this torrent of installing problems.

Guys please merge #211 as soon as possible. Ican't build my app because of this issue:
https://github.com/wix/react-native-ui-lib/issues/223

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jp928 picture jp928  路  4Comments

tikkichan4 picture tikkichan4  路  5Comments

motiazu picture motiazu  路  5Comments

TomAtterton picture TomAtterton  路  3Comments

m10653 picture m10653  路  4Comments