React-native-image-crop-picker: Cancel at cropper cause error

Created on 21 Apr 2019 · 2Comments · Source: ivpusic/react-native-image-crop-picker

Version

Tell us which versions you are using:

react-native-image-crop-picker v0.23.1
react-native v0.59

Platform

Expected behaviour

openPicker with Cropper -> select image -> cancel at cropper -> select another image -> confirm at copper -> an image should be returned.

Actual behaviour

openPicker with Cropper -> select image -> cancel at cropper -> select another image -> confirm at copper -> no image is returned.

Turn on debug mode show:
The callback openPicker() exists in module ImageCropPicker; but only one callback my be registered to a function in a native module.

Steps to reproduce

openPicker with Cropper, select image , cancel at cropper
select another image
confirm at copper

// stacktrace or any other useful debug info

Love react-native-image-crop-picker? Please consider supporting our collective:
👉 https://opencollective.com/react-native-image-crop-picker/donate

Source

fergusko

👍2

Most helpful comment

Possible Fix ?

ImageCropPicker.m

(void)imageCropViewControllerDidCancelCrop:
(RSKImageCropViewController *)controller {
[self dismissCropper:controller selectionDone:NO completion:[self waitAnimationEnd:^{
if (_self.currentSelectionMode != PICKER &&_ (self.currentSelectionMode == CROPPING || [[self.options objectForKey:@"cropping"] boolValue])) {
self.reject(ERROR_PICKER_CANCEL_KEY, ERROR_PICKER_CANCEL_MSG, nil);
}
}]];
}

fergusko on 21 Apr 2019

❤5 👍2

All 2 comments

Possible Fix ?

ImageCropPicker.m

(void)imageCropViewControllerDidCancelCrop:
(RSKImageCropViewController *)controller {
[self dismissCropper:controller selectionDone:NO completion:[self waitAnimationEnd:^{
if (_self.currentSelectionMode != PICKER &&_ (self.currentSelectionMode == CROPPING || [[self.options objectForKey:@"cropping"] boolValue])) {
self.reject(ERROR_PICKER_CANCEL_KEY, ERROR_PICKER_CANCEL_MSG, nil);
}
}]];
}