React-native-image-crop-picker: RSKimageCropper issue

[iOSHw]

Version

Tell us which versions you are using:

• react-native-image-crop-picker v0.12.8
• react-native v0.42.0

Platform

Tell us to which platform this issue is related

• iOS

Expected behaviour

run issue xcode 8.2 has no problem ,when i run in # xcode 8.3 ,it make problem

Actual behaviour

Redefinition of module 'RSKImageCropper' issue

Steps to reproduce

1.

2.

3.

Attachments

// stacktrace or any other useful debug info

[iOSHw]

@ivpusic

[darrenchiu]

+1
seems this happened after updating xcode and macos today

[iOSHw]

[springwq]

The same issue found, Xcode 8.3, macOS 10.12.4

[juxiaowei]

+1
seems this happened after updating xcode and macos today

[iOSHw]

@ivpusic help！

[habovh]

Can confirm this is happening on Xcode 8.3, it is unrelated to the macOS update (I'm still on 10.12.3).
It seems that the module.modulemap exists both under node_modules folder and in Xcode's derived data folder, which result in the redefinition error.

See the path of the files here:

[eiosca]

There is an update here, i'm trying to switch to cocoapods

https://github.com/ruslanskorb/RSKImageCropper/commit/7d5ea88c7e6fd7840cff598cc4cf7d9aafd027ac

[ivpusic]

@iOSHw please try commit from @eiosca

[iOSHw]

@ivpusic what time will you fix this issue ?

[NewBen001]

@eiosca Did you fix this problem ?

[eiosca]

@NewBen001 yes, but with the bad solution.
Just following the message's commit of https://github.com/ruslanskorb/RSKImageCropper/commit/7d5ea88c7e6fd7840cff598cc4cf7d9aafd027ac

Go to folder

node_modules/react-native-image-crop-picker/ios

rename the file

module.modulemap > RSKImageCropper.modulemap

then edit the file RSKImageCropper.xcodeproj/project.pbxproj
and add this line two times (in debug and release part Cf Commit):
MODULEMAP_FILE = "$(SRCROOT)/RSKImageCropper/RSKImageCropper.modulemap";

Clean and build. It should be works.

PS: It was a fail to me to switch on cocoapods, that's why i'm doing that and waiting for the fix.
I will try to work on a PR this week-end but not sure.

[basilbai]

This question has affected my job......

[krailler]

I have same issue.. :/

[krailler]

modification of @eiosca solve issue <3

[ivpusic]

@eiosca could you send pull request?

[eiosca]

@ivpusic Yeah, like i said i will try this week-end :-)

[ivpusic]

if someone can do it even sooner, PR will be welcome

[magrinj]

I create a PR: #282, thanks to @eiosca! => It works well :)

If you want to use the PR until the merge, just do the following:

react-native unlink react-native-image-crop-picker

Edit your package.json:

"react-native-image-crop-picker": "git+https://github.com/magrinj/react-native-image-crop-picker.git#fix-rkimagecropper",

Then

react-native link react-native-image-crop-picker

And Replace pod 'RSKIMageCropper in your podfile by (until it will be released on cocoapods):

pod 'RSKImageCropper', :git => 'https://github.com/ruslanskorb/RSKImageCropper.git', :branch => 'master'

Update:
RSKImageCropper was release in 1.6.1 with the fix, you can now use all version over 1.6.1

[ivpusic]

released in https://github.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.12.9

[cwRichardKim]

@ivpusic any way to access this from rn 0.29?

[habovh]

@cwRichardKim you could fork the repo to a point in time where it was RN 0.29 compatible, and do the same changes that were done in PR #282.

[cwRichardKim]

@habovh ended up upgrading to .42. it was a nightmare, but finally managed to get it to work

[magrinj]

If you use cocoa pods and you try to build it in release mode, you're going to get a failed compilation, because you need to change this in you Podfile (until it will be released on cocoapods):
From

pod 'RSKImageCropper'

To

pod 'RSKImageCropper', :git => 'https://github.com/ruslanskorb/RSKImageCropper.git', :branch => 'master'

Update:
RSKImageCropper was release in 1.6.1 with the fix, you can now use all version over 1.6.1

[kornerr]

RSKImageCropper 1.6.1 has the issue fixed and works fine with Xcode 8.3.1