React-native-gifted-chat: Remove the dependency on react-native-video

Created on 26 Apr 2019  路  8Comments  路  Source: FaridSafi/react-native-gifted-chat

Video playback seems out of the scope of this project and creates a lot of headaches.

  • If you are already using react-native-video in your project, adding this library will break it
  • This library uses an outdated version of react-native-video so even if you jump through the hoops of using the version in this library, instead of the one you installed yourself, you now must use an old version

This would resolve a number of open issues. Most notably...

https://github.com/FaridSafi/react-native-gifted-chat/issues/1093
https://github.com/FaridSafi/react-native-gifted-chat/issues/1172

Most helpful comment

not stale

All 8 comments

Yes please, I cannot use react-native-video as well as gifted chat in the same project. I might end up having to remove gifted chat if this issue is not resolved.

For the moment I just run a postinstall:
"postinstall": "rimraf node_modules/react-native-gifted-chat/node_modules/react-native-video",
But agree it should be made a peerDependency

Any update on this? Will this be fixed or should we implement the workarounds posted?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

not stale

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

not stale

Now removed

Was this page helpful?
0 / 5 - 0 ratings