React-native-gifted-chat: Typescript support

[ascariandrea]

Issue Description

Missing type definition for typescript

Additional Information

No plan to add types definition for typescript?

[xcarpentier]

Why not... do you any resources somewhere or guideline to do it?
Or maybe a PR?

[ascariandrea]

I will be happy to submit a PR :)

[xcarpentier]

👌

[jpmoyn]

Hey @ascariandrea are you working on the types for this? It would be awesome to have this for a project im working on!

[ascariandrea]

@jpmoyn I'm gonna work on this in the next days

[omkar-joshi]

@ascariandrea @xcarpentier Any update on this? I really need type definitions to continue using react-native-gifted-chat. I'm ready to submit a PR if you guys are busy. 🙂

[ascariandrea]

It's been released with v0.4.3 @omkarjoshi-cc

[omkar-joshi]

Thanks! @ascariandrea @xcarpentier

[omkar-joshi]

Hey! There seems to be a problem with the latest release v0.4.3.
I tried installing using
npm i react-native-gifted-chat --save and
npm i [email protected] --save but the index.d.ts is not getting installed.
I even tried installation using
npm i https://github.com/FaridSafi/react-native-gifted-chat#v0.4.3 but no luck. Can anyone of you please look into this? @ascariandrea @xcarpentier

[xcarpentier]

You should use master.
I will fix the package issue soon with next fix 0.4.4

[omkar-joshi]

Thanks! 🙂

[ascariandrea]

Can we close this @xcarpentier ?

[omkar-joshi]

@xcarpentier @ascariandrea
The type for showAvatarForEveryMessage in GiftedChatProps is missing in the current typedefs. I've added it to the typedefs in my fork and I'm using it locally. I've also fixed the this along with it. Shall I submit a PR for these minor fixes?

[ascariandrea]

Good job!
You should, definitely!

[brunolemos]

It shouldn't be required to use master to have the types

[mjrdnk]

Is this fixed? Both master and 0.4.3 do not install declarations file.
Can we fix this?

[lucsky]

Why is this closed ? Typescript types are definitely not available when installing current version (0.4.3).

[bkonkle]

Same here - types are still unavailable.

[sibelius]

Master has types, check the code

[lucsky]

@sibelius yes that is the point: master has types, the release (0.4.3 at this moment) does not.

[sibelius]

@lucksy can u test against master? If everything is fine with master I can do another release

[lucsky]

@sibelius Just tested with 0.5, everything's fine.

(well, except for that imageStyle prop, but that's already fixed in master...)

Thanks!

[cmcaboy]

It appears to be working with 0.5 for me as well.

[xcarpentier]

1190