React-native-firebase: React 0.56 support

[IljaDaderko]

Issue

Updating to react native v0.56.0 requires flow bin update to ^0.75.0 which results in following errors

Error ┈┈┈┈┈ node_modules/react-native-firebase/dist/modules/firestore/Query.js.flow:417:20

Property fieldpath is missing in NativeFieldPath [1].

 [1]  46│   fieldPath: NativeFieldPath,
        :
     414│           fieldOrder.fieldPath.string
     415│         ) {
     416│           values.push(docSnapshot.get(fieldOrder.fieldPath.string));
     417│         } else if (fieldOrder.fieldPath.fieldpath) {
     418│           const fieldPath = new FieldPath(...fieldOrder.fieldPath.fieldpath);
     419│           values.push(docSnapshot.get(fieldPath));
     420│         }


Error ┈┈┈┈ node_modules/react-native-firebase/dist/modules/storage/reference.js.flow:77:12

Cannot return new StorageTask(...) because StorageTask [1] is incompatible with
Promise [2].

     74│    * @return {Promise}
     75│    */
 [2] 76│   downloadFile(filePath: string): Promise<Object> {
 [1] 77│     return new StorageTask(
     78│       DOWNLOAD_TASK,
     79│       getNativeModule(this._storage).downloadFile(this.path, filePath),
     80│       this
     81│     );
     82│   }
     83│
     84│   /**


Error ┈┈┈ node_modules/react-native-firebase/dist/modules/storage/reference.js.flow:100:12

Cannot return new StorageTask(...) because StorageTask [1] is incompatible with
Promise [2].

      97│    */
 [2]  98│   putFile(filePath: Object, metadata: Object = {}): Promise<Object> {
      99│     const _filePath = filePath.replace('file://', '');
 [1] 100│     return new StorageTask(
     101│       UPLOAD_TASK,
     102│       getNativeModule(this._storage).putFile(this.path, _filePath, metadata),
     103│       this
     104│     );
     105│   }
     106│ }
     107│

Environment

1. Application Target Platform: iOS

1. Development Operating System: macOS High Sierra

1. Build Tools: Not needed

1. React Native version: 0.56.0

1. React Native Firebase Version: 4.2.0

1. Firebase Module: firestore, storage

1. Are you using typescript? no

---

Loving react-native-firebase? Please consider supporting them with any of the below:

• 👉 Back financially via Open Collective
• 👉 Follow React Native Firebase and Invertase on Twitter
• 👉 Star this repo on GitHub ⭐️

[Salakar]

@IljaDaderko rn 56 has backwards compatible breaking changes so support for it will only land in v5.0.0, we have started work on it in this branch already: https://github.com/invertase/react-native-firebase/tree/react-native-56

Thanks for the heads up!

---

Loving react-native-firebase and the support we provide? Please consider supporting us with any of the below:

• 👉 Back financially via Open Collective
• 👉 Follow React Native Firebase and Invertase on Twitter
• 👉 Star this repo on GitHub ⭐️

[leethree]

We already upgraded our project to React Native v0.56. Should I use the current version (v4.3.6) or wait for v5? Is there anything known to break in v4 other than flow errors (which we can ignore)?

[Salakar]

@leethree there's this issue and all the ones linked above your comment e.g. there are issues with importing and using react-native-firebase in JS land due to breaking changes in the way the module is compiled with Babel; as it has been upgraded to v7:

Support will land in v5 in the next week or two hopefully.

---

Loving react-native-firebase and the support we provide? Please consider supporting us with any of the below:

• 👉 Back financially via Open Collective
• 👉 Follow React Native Firebase and Invertase on Twitter
• 👉 Star this repo on GitHub ⭐️

[leethree]

@Salakar got it! we'll probably wait for v5 if it's coming soon.

[smkhalsa]

@Salakar any idea when v5 will land?

[Salakar]

@smkhalsa hey; we're aiming for a release on the 7th. Thanks

[Salakar]

@IljaDaderko @leethree @smkhalsa and anyone else - React Native ^0.56.0 support is on master for anyone feeling daring.

Would be helpful if anyone could try it - 0.56 broke our testing infra so it's going to take me a couple of days to re-write it all again 😭 - I have manually tested builds etc and all seems fine - including the flow issues above posted by @IljaDaderko being resolved.

If you're on v4.3.x currently then your only update step (for now - v5 still WIP) is updating to RN 0.56.0 and all your babel versions as described in the RN 56 release notes.

See https://github.com/invertase/react-native-firebase/blob/master/bridge/package.json for an example app running the latest versions.

---

Testing infra is going to delay v5 release - but I can publish a next tagged release that works with RN 56 once confirmed all ok - so you can live on the bleeding edge while v5 is worked on.

---

Update:

npm i react-native-firebase@next

[timwangdev]

Hi @Salakar , can you make a RC release? I tried to use master branch for testing but the files is not bundled and I need to manually build it.

[Salakar]

@timwangdev as requested;

npm i react-native-firebase@next

As always please report any issues you find, additionally can you tag them [next] on your GitHub issue titles so I can pick them up easier.

Thanks 👍

[alexichristakis]

I just tried upgrading my project to the RC and im stuck getting the error:

unable to resolve module '../crash' from `/Users/alexic/react-native/sesh/node_modules/react-native-firebase/dist/modules/core/firebase.js`: The module `../crash` could not be found from `/Users/alexic/react-native/sesh/node_modules/react-native-firebase/dist/modules/core/firebase.js`. Indeed, none of these files exist:

but it looks like firebase.js isn't requiring such a module. I tried reinstalling the package with no luck.

[Salakar]

@alexichristakis can you try reset your rn packager cache, start it with --reset-cache

[alexichristakis]

@Salakar still no luck

[Salakar]

Can you try npm i [email protected] - specifying the version specifically?

[alexichristakis]

rolling back to an old branch and reinstalling now. maybe something got messed up the first time...

[Salakar]

Ok, am on discord as well if you still continue to have issues ping me on there and I can take a look

[Salakar]

Confirmed working on npm i [email protected]. Closing this issue pending the full release of v5.

---

Loving react-native-firebase and the support we provide? Please consider supporting us with any of the below:

• 👉 Back financially via Open Collective
• 👉 Follow React Native Firebase and Invertase on Twitter
• 👉 Star this repo on GitHub ⭐️

[NicholasBertazzonAga]

@Salakar
Hi, I managed to get it working (I mean the unable to resolve module problem) by doing this:

watchman watch-del-all && rm -rf $TMPDIR/react-* && rm -rf node_modules/ && npm cache clean --force && npm install && npm start -- --reset-cache

It was indeed a problem of cache, expecially because the new metro bundler on react native 0.57 is strange when installing/updating packages when it's already running.

[gianpaj]

If I have a RN v0.56 app and currently using RNFilrebase v4.2.0, should I upgrade the latest v4.3.x or wait until the v5.0 is released?

[timwangdev]

@gianpaj You could use @next release. It works fine on our project.
@Salakar It's better to see 5.0.0 release coming soon, of cause.

[IljaDaderko]

@Salakar I will be playing with my side project this weekend can try out latest v5 rc, should it be compatible, is it by any chance compatible with rn 0.57.x, so I can try both? Also which versions of firebase ios sdk should be used?

[Salakar]

@IljaDaderko it is fully compatible with 0.56 & 0.57 now - our tests app runs on 0.57, see react-native-firebase/tests if you'd like - as a reference to which versions of RN/React/Firebase etc to use 👍

I'll be about most of the weekend on Discord so feel free to drop me a DM if you have any issues or need an assist.

See the pinned messages on Discord in the #pre-releases channel for RC release notes - latest is RC4 from yesterday.

[quachsimon]

We are going to be updating our project from 0.55.4 -> 0.57 in the coming weeks. We are currently on RNFirebase v4.3.8, the latest one is v5.1.x.

Should we update from v4.3.8 -> v5.0.0 then from v5.0.0 -> v5.1.0? or can we just make the jump from v4.3.8 -> v5.1.0?

I looked at the docs and wasn't sure if that's possible.

https://rnfirebase.io/docs/v5.x.x/release-notes#React-Native