React-native-firebase: Any plan to support DFP as well? (DFPBannerView etc.)
giladno
All 6 comments
Hey, a rework of Admob is planned for 4.3.0 release. Whether or not we integrate DFP is to be decided, as it does fall outside of Firebase. That being said, once there's a solid, tested implementation for Admob we may release a standalone DFP package as we'd already have a good base to work from.
Ehesp
on 17 May 2018
Looks like Admob support was added in v6. Are there any new plans to add DFP support?
ianwelsh
on 3 Oct 2019
@ianwelsh we're only supporting what Firebase provides in this library. Honestly though, my knowledge of AdMob vs DPF isn't great. From what I see, supporting DFP would require additional SDKs and "non-Firebase" products.
Ehesp
on 3 Oct 2019
@Ehesp I'm not sure whether it's considered "non-Firebase", but it seems to use the same SDKs as AdMob. For instance, it's included in com.google.android.gms.ads on Android and GoogleMobileAds on iOS, both of which are in the https://firebase.google.com docs.
ianwelsh
on 3 Oct 2019
Hi @Ehesp, would a PR for DFP support be accepted on the repository?
There's not a lot of difference between a DFPBanner and GADBanner, since DFPBanner inherits from GADBanner, so I'd be happy to submit a PR here.
Almouro
on 25 Sep 2020
@Almouro I'm the person-currently-merging things and I'd consider a PR if it was small. If you look at the structure of the libraries, I challenge you to find the "Ads related firebase things" here:
https://firebase.google.com/docs/reference/android/packages (there are ads of course, but inside firebase scope?)
https://github.com/firebase/firebase-android-sdk/
https://github.com/firebase/firebase-ios-sdk/
My point being that AdMob does not really belong in a Firebase wrapper. This should all be in https://github.com/sbugert/react-native-admob and we should delete all AdMob-related items from here
So if at all possible I encourage you to focus effort on react-native-admob which should have a future, whereas development in AdMob here - from a philosophical position of where things should be - is a dead-end
mikehardy
on 25 Sep 2020
Related issues
rtman
路
3Comments
joecaraccio
路
3Comments
Damnum
路
3Comments
n-scope
路
3Comments
jonaseck2
路
3Comments
Most helpful comment
Hey, a rework of Admob is planned for 4.3.0 release. Whether or not we integrate DFP is to be decided, as it does fall outside of Firebase. That being said, once there's a solid, tested implementation for Admob we may release a standalone DFP package as we'd already have a good base to work from.