React-native-firebase: Issue with global variables and other libs

Created on 31 Aug 2017  路  1Comment  路  Source: invertase/react-native-firebase

I just came across the issue I described here.

The issue was caused by that line - IMHO using global variables is extremely dangerous. can you guys fix this?

Invalid Question
Source
picture sirilicious

Most helpful comment

@sirilicious Dangerous how exactly? ;p RN isn't the same as the web, it's a closed global with the only way to access it being via the apps code itself, there's no web console on the device, same thing applies for node server side apps. The 'danger' is only for websites (as there's a console), or apps that use eval() - when they shouldn't be.

Having said that, this was needed for bows to work annoyingly - however I'd like to get rid of it as a dependancy and plan to do so in the next couple of days whilst working on the next alpha for v3.

picture Salakar on 31 Aug 2017
👍2

>All comments

@sirilicious Dangerous how exactly? ;p RN isn't the same as the web, it's a closed global with the only way to access it being via the apps code itself, there's no web console on the device, same thing applies for node server side apps. The 'danger' is only for websites (as there's a console), or apps that use eval() - when they shouldn't be.

Having said that, this was needed for bows to work annoyingly - however I'd like to get rid of it as a dependancy and plan to do so in the next couple of days whilst working on the next alpha for v3.

Salakar picture Salakar on 31 Aug 2017
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

kumarpatel picture kumarpatel  路  3Comments
Draccan picture Draccan  路  3Comments
noahtallen picture noahtallen  路  3Comments
rtman picture rtman  路  3Comments
jgfidelis picture jgfidelis  路  3Comments