React-native-fbsdk: Migration to RN 0.29

[avishayil]

https://github.com/facebook/react-native/commit/49f20f41546e3ba8e7fe43c84c4c701684d0434d

[ericraio]

@avishayil looks like the main activity needs to be implemented into this package.

Those packages need to be updated so that they don't need the activity to be passed in the constructor. The correct way is to extend ReactContextBaseJavaModule and use the getCurrentActivity() method.

[ericraio]

@dzhuowen what do you think?

[dzhuowen]

Currently the sdk package is tied to the main activity so the workaround for RN0.29 would be passing the activity into the package class and init the callback manager there. Haven't try it myself but will look into it.

[satya164]

Something like this might work - https://gist.github.com/satya164/bc9e6f16f2d86a622e82ea795cc8292b

[donedgardo]

Im sorry but how would we implement that gist?
Sorry not a Java developer.

[satya164]

@donedgardo Modify your MainActivity.java and MainApplication.java according to the gist.

[brien-crean]

This is very unclear from a non android / non Java developer perspective. The how to docs need an update. I cannot integrate this SDK with 0.29 at present. I have tried following the README and also the gist that was supplied in the comments above but keep getting cannot find symbol errors like,
error: cannot find symbol new FBSDKPackage(mCallbackManager)

[satya164]

@brien-crean Probably you didn't import the FBSDKPackage? Use Android Studio to edit Java files. It auto-imports packages.

[dzhuowen]

Readme updated with instruction for rn 0.29+
Feel free to comment if you see further issues.