React-native-elements: Update Card to use new Image Component

Created on 22 Dec 2018  路  3Comments  路  Source: react-native-elements/react-native-elements

Now that we have the Image component that allows gradual image loading we should use it in the Card component.

鉁‥nhancement

Most helpful comment

Hi @CMarshall92! 馃憢

Here's what you need to do:

  • Fork this Github repo
  • Once forked, clone the fork to your machine

    • git clone https://github.com/{username}/react-native-elements.git

  • Check out the next branch

    • git checkout next

  • Make changes as needed

    • Ideally you should checkout a new branch from next and name it something like improve_card_component

  • Once done, commit and push your code to your branch.
  • Finally, on your repo click on "New Pull Request" on the Pull Request tab

    • Once you do that, select "react-native-elements/next" as the base and click "Create"

This is create a new PR to this repo with your new changes. Hope this helps @CMarshall92 @mitulsavani

/cc @iRoachie let's put this in the contributing guide so it might be useful for other beginners.

All 3 comments

I have updated the component would like to push but don't have access to push. How do I request access to make a pr?

Hi @CMarshall92! 馃憢

Here's what you need to do:

  • Fork this Github repo
  • Once forked, clone the fork to your machine

    • git clone https://github.com/{username}/react-native-elements.git

  • Check out the next branch

    • git checkout next

  • Make changes as needed

    • Ideally you should checkout a new branch from next and name it something like improve_card_component

  • Once done, commit and push your code to your branch.
  • Finally, on your repo click on "New Pull Request" on the Pull Request tab

    • Once you do that, select "react-native-elements/next" as the base and click "Create"

This is create a new PR to this repo with your new changes. Hope this helps @CMarshall92 @mitulsavani

/cc @iRoachie let's put this in the contributing guide so it might be useful for other beginners.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kyleatblackfoot picture kyleatblackfoot  路  3Comments

guitar9 picture guitar9  路  3Comments

motogod picture motogod  路  3Comments

xavier-villelegier picture xavier-villelegier  路  3Comments

Tonacatecuhtli picture Tonacatecuhtli  路  3Comments