React-native-device-info: hasNotch not working on Pocophone F1

Created on 1 Mar 2019  路  4Comments  路  Source: react-native-device-info/react-native-device-info

Summary

DeviceInfo.hasNotch() returns false on PocoPhone F1

Version: 0.26.4
Affected OS: Android
OS Version: 9

android bug
Source
picture NemanjaManot

Most helpful comment

Fixed

picture machour on 13 Mar 2019
👍3

All 4 comments

The Poco F1 is in the list of devicesWithNotch and so should return true. What does it show if you call console.log(DeviceInfo.getModel()) from your Poco F1?

https://github.com/rebeccahughes/react-native-device-info/blob/9d92e55dfe9bc6271887a4637ef0d5b95eb44205/deviceinfo.js#L177-L180

edreyyo picture edreyyo on 5 Mar 2019

@edreyyo
'POCOPHONE F1'

NemanjaManot picture NemanjaManot on 5 Mar 2019

Thanks, I have just submitted a fix @NemanjaManot. It will need to be approved by the repository owner.

edreyyo picture edreyyo on 7 Mar 2019

Fixed

machour picture machour on 13 Mar 2019
👍3
Was this page helpful?
0 / 5 - 0 ratings

Related issues

jnranawedo picture jnranawedo  路  3Comments
jmunozDevsu picture jmunozDevsu  路  4Comments
Ken-Lim picture Ken-Lim  路  5Comments
HAPENLY picture HAPENLY  路  5Comments
dozel picture dozel  路  4Comments