React-native-device-info: Android causes errors when app uses Firebase

Created on 2 Dec 2016  路  5Comments  路  Source: react-native-device-info/react-native-device-info

Our CI build broken after adding this. Upon further inspection, it's a conflict that stems from instanceId using GCM. I would suggest removing instanceId entirely, as it will avoid any Google Play dependencies, plus it doesn't work for Firebase anyway.

Most helpful comment

You got it. Give me a few days and I'll hit you up with the PR.

All 5 comments

I'm inclined to make this change... I feel this dependency causes lots of headache.

Go ahead and do a PR to remove it, and I'll discuss with a few people to get this pushed through.

You got it. Give me a few days and I'll hit you up with the PR.

@StevePotter - glad you're on it. When it's 100% I'll release version 0.10.0

@StevePotter did you ever fork or do a PR here?

Closing this in favor of #187 which contains more comments.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

clozr picture clozr  路  5Comments

truckhiem picture truckhiem  路  4Comments

pgonzalez-santiago picture pgonzalez-santiago  路  3Comments

ercpereda picture ercpereda  路  5Comments

Ken-Lim picture Ken-Lim  路  5Comments