React-native-debugger: [RN 0.56] Context menu functions are broken

Created on 6 Jul 2018  路  2Comments  路  Source: jhen0409/react-native-debugger

Looks like https://github.com/facebook/react-native/pull/18995 breaks the global window.require usage, so context menu will be broken with related modules.

Here is the expected solution for update RNDebugger:

  • MessageQueue: We can use Object.getPrototypeOf(__fbBatchedBridge).constructor instead
  • setupDevtools: It used for backward compatible (RN < 0.39), just remove that as latest version of react-devtools have been removed the backward compatible
  • Other modules: We can change to use window.require(1), 1 is the ReactNative module id, but I'm yet to sure if some case will change the module id

We should also update the documentation.

bug

Most helpful comment

@RodolfoSilva Yes, I've released it as v0.7.19.

All 2 comments

Hey @jhen0409 nice work with this app, do you have any forecast to generate a new release?

@RodolfoSilva Yes, I've released it as v0.7.19.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

freerangenerd picture freerangenerd  路  17Comments

jgcmarins picture jgcmarins  路  23Comments

eshikerya picture eshikerya  路  39Comments

AdrienLemaire picture AdrienLemaire  路  17Comments

blackxored picture blackxored  路  16Comments