React-native-code-push: release-react fails for Android app with dynamic build.gradle

[willmortonscoot]

Steps to Reproduce

1. Have the following section in android/app/build.gradle (other config removed for clarity):

def getVersionName = { ->
    return project.hasProperty('versionName') ? versionName : "0.0.1"
}

android {
  defaultConfig {
    versionName getVersionName()
  }
}

1. Run React Native app as normal (this works fine)

react-native run-android

1. Create a codepush release:

appcenter codepush release-react -a <app_name>

Expected Behavior

The release is created.

Actual Behavior

The release fails with error:

Detecting android app version:

Error: Command 'codepush release-react -a will.morton-1/Scoot-Android' failed with exception "No property named "getVersionName()" exists in the "android/gradle.properties" file."

Changing the versionName to a static string removes the error, so the issue appears to be that the bundler is not interpreting the file as gradle but rather grepping for the value - this is at odds with the react-native build system itself.

This error suggests that codepush will not support any dynamic methods within a build.gradle file, which is a fairly major limitation.

Environment

• react-native-code-push version: 5.2.1
• react-native version: 0.52.1

[iTOYS]

Hi @willmortonscoot

Unfortunately we can't execute getVersionName() but CLI require version.
To avoid this error you should use -t|--target-binary-version option:

appcenter codepush release-react -a <app_name> -t <version>

Thanks!