React-native-code-push: React Native 0.45 support

Created on 8 Jun 2017  路  12Comments  路  Source: microsoft/react-native-code-push

Is React Native 0.45 supported yet?

compatibility fix-in-master

Most helpful comment

Hey guys, the issue I've created https://github.com/facebook/react-native/issues/14533 is probably stuck, so I've investigated it deeper and I believe that I've implemented solution that should fix it - PR https://github.com/Microsoft/react-native-code-push/issues/901.

Could you guys please try this PR and let me know if it works or if you see any issues? Please also let me know if you see some improvements for this PR.

In case provided solution works - we'll release new version of react-native-code-push and I'll also try to prepare and publish PR in React Native.

All 12 comments

Hi @sattaman, thanks for reaching us, we will check for compatibility soon and will update this table. We also let you know if any updates.

I run 0.45 in production with code push. Currently everything is okay.

Hey guys, I would recommend you to avoid of using CodePush with RN 0.45 for now, due to new version of RN has some breaking changes that does not allow CodePush to reload js bundle, in another words CodePush.restartApp and the following install mods are not work with RN 0.45: IMMEDIATE, ON_NEXT_RESUME, ON_NEXT_SUSPEND.
I've also created new issue in RN: https://github.com/facebook/react-native/issues/14533

So I'll let you know if any updates.

@sergey-akhalkov thanks for the warning. Sorry for confusion on iOS is everything is okay. Can confirm that im also encountered with the same issue on Android described above.

Ok @sergey-akhalkov so does that mean that if we use ON_NEXT_RESTART it's fine to still use RN 0.45 on both iOS and Android?

Hi @SudoPlz, correct, ON_NEXT_RESTART install mode works well both for Android and iOS.

Awesome, thanks Sergey!

I haven't been able to CodePush work on RN 0.45.1, even with ON_NEXT_RESTART. I tried using the HOC and calling sync directly with the same results.

When I force quit the app to force the CodePush install, the app crashes. I've tested this on iOS.

Same here, ~only works on restarts! But its really important to get ON_NEXT_RESUME running, seriously who is restarting his apps 馃拑 ? Anyone tried to manually download and refresh the bundle on the app resume event? I had a workaround some time ago.~

Just tested it again and it seems to work also on resume. Maybe its not reliable and sometimes fails for some reason?

Also note that if you used the --mandatory flag it forces a restart, which will also cause a crash.

Hey guys, the issue I've created https://github.com/facebook/react-native/issues/14533 is probably stuck, so I've investigated it deeper and I believe that I've implemented solution that should fix it - PR https://github.com/Microsoft/react-native-code-push/issues/901.

Could you guys please try this PR and let me know if it works or if you see any issues? Please also let me know if you see some improvements for this PR.

In case provided solution works - we'll release new version of react-native-code-push and I'll also try to prepare and publish PR in React Native.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ACCTFORGH picture ACCTFORGH  路  3Comments

SudoPlz picture SudoPlz  路  4Comments

chrisjrex picture chrisjrex  路  4Comments

jaysig picture jaysig  路  3Comments

Phredward picture Phredward  路  3Comments