React-native-code-push: disallowRestart not working

[claykohut]

Disallow restart doesn't seem to be working for me.

I have installMode set to ON_NEXT_RESUME and am setting disallowRestart in a componentDidMount. The app is logging the disallow restart but still restarts on resume after disallowRestart is called.

Can anyone please help?

Additional Information

• react-native-code-push version: 1.17.2-beta (same issue with 2.0.1-beta)
• react-native version: 0.39.0
• iOS version: 10.3
• Does this reproduce on a debug build or release build? Both
• Does this reproduce on a simulator, or only on a physical device? Both

[sergey-akhalkov]

Hi @claykohut, thanks for reaching us. I've investigated the issue, seems like there is a mismatch between the documentation and implementation. Documentation says that disallowRestart works with InstallMode.ON_NEXT_RESUME, but from the source code I can see the following:

1. disallowRestart method affects RestartManager.restartApp method
2. RestartManager.restartApp is used by install method only in case InstallMode.IMMEDIATE is in use
3. App restarts programmatically via native side both for Android and iOS due to _allowed flag does not used by native side.

As result disallowRestart feature works for InstallMode.IMMEDIATE only. For now we are working on Support Brownfield React Native apps feature, so we'll move _allowed flag to the native side and use it further for ON_NEXT_RESUME, ON_NEXT_SUSPEND https://github.com/Microsoft/react-native-code-push/pull/770 and IMMEDIATE installation modes, so the issue will be fixed.

Please let me know if you have any questions.

[joeferraro]

@sergey-akhalkov any idea when this might make it into a release?

[sergey-akhalkov]

Hi @joeferraro, thanks for reaching us. We've already implemented "Support for Brownfield React Native apps" feature that also includes this improvement, here you can find my fork. Here you can see native RestartManager where the issue is fixed.
The main problem why we aren't merging this is that we need to test "Support for Brownfield React Native apps" very carefully and deeply to avoid as much issues as possible. So currently we are testing this, so we will be very grateful if you could help us to test it if possible.

[ruslan-bikkinin]

@amardeepranu thanks for the interest, we are planning to release a new version including fix for that during this month.

[MrLoh]

Has this been release yey, and does it also apply to ON_NEXT_SUSPEND, the docs only mention ON_NEXT_RESUME at the moment.

[sergey-akhalkov]

Hi @MrLoh, thanks for reaching us.

Has this been release yey

Unfortunately, no, currently we have other priorities, but we'll back to this asap.

and does it also apply to ON_NEXT_SUSPEND, the docs only mention ON_NEXT_RESUME at the moment.

after releasing "support for brownfield apps" feature it will support both ON_NEXT_RESUME and ON_NEXT_SUSPEND

[kevinresol]

Any updates? This has been idle for almost an year.

[canyara]

not fix yet

[Adichilla]

Please have a Look at this
https://github.com/Microsoft/react-native-code-push/issues/1550

[achou11]

I think I'm noticing this issue for my app as well. Commented on https://github.com/microsoft/react-native-code-push/issues/1667#issuecomment-549440553 with some context but I'll repeat it here:

This is happening on React Native 0.61.3 with installMode set to ON_NEXT_RESUME on Android.

1. CodePush installs an update on app start.
2. Opens an in-app-browser for auth. disallowRestart is called and the Disallowing restarts log is present.
3. After entering credentials successfully, redirects to the app but CodePush causes a restart even though allowRestart hasn't been called.

[andreidubov]

Hi @achou11 @claykohut @kevinresol
Sorry for the delay.

We have prepared a PR (#1894) to solve this problem, if you have the time and desire, you can take a look at it.

[andreidubov]

Hi @achou11 @claykohut @kevinresol

We made a new release with this feature, thanks for your participation.