React-native-code-push: RN 40 support

Created on 11 Jan 2017 · 17Comments · Source: microsoft/react-native-code-push

RN version .40 is already published with a major breaking change. Can we update the example app and docs to support RN 40.

Source

chirag04

👍9

Most helpful comment

Fix has shipped here https://github.com/facebook/react-native/commit/545072b02d94e264a66987a5cebc15629a16f188. Watch out for a new release to land today or tomorrow

grabbou on 13 Jan 2017

👍3 ❤1

All 17 comments

@chirag04 - hi!
There are two PRs, #665 and #638 are waiting to be merged and released. Hoping this will happen soon.

sergey-akhalkov on 11 Jan 2017

👍1

As already noted in the react-native repo, from the link perspective, it doesn't really matter. Just to say that #665 is not currently supported by the react-native link and so, using it will add headers to search paths anyway. If we decide to merge it, we need to release support for that with react-native at the same time.

Happy to consider, just need to release the fix in first place.

grabbou on 11 Jan 2017

"react-native": "0.40.0",
"react-native-code-push": "^1.16.1-beta",
xcode Version 8.2.1 (8C1002)

iPhone 6s Plus Release Error
iPhone 6s Plus Debug is ok

JusticeLai on 12 Jan 2017

@grabbou, got it, thanks!
It would be great to support #665 due to benefits you've described in https://github.com/facebook/react-native/issues/11747#issuecomment-271989016.

That approach seems better as it doesn't pollute global namespace and reduces one more step when user links "manually".

So after releasing react-native link ... updates we would merge #655 and update the react-native-code-push documentation.

sergey-akhalkov on 12 Jan 2017

@JusticeLai - hi!
I've got the same issue using initial react-native app, so I've created https://github.com/facebook/react-native/issues/11861

sergey-akhalkov on 12 Jan 2017

I'll then ship two things now, 1) the fix 2) that new features. Will update this issue accordingly.

grabbou on 12 Jan 2017

Fix has shipped here https://github.com/facebook/react-native/commit/545072b02d94e264a66987a5cebc15629a16f188. Watch out for a new release to land today or tomorrow

grabbou on 13 Jan 2017

👍3 ❤1

@grabbou, got it, thanks!

sergey-akhalkov on 13 Jan 2017

@sergey-akhalkov
still same error,

Have you solved it?

JusticeLai on 14 Jan 2017

@grabbou any update on the next release with .40 support? Thx!

stirman on 16 Jan 2017

@JusticeLai, I've applied this https://github.com/facebook/react-native/pull/11889/files changes and got build success message in release mode.

sergey-akhalkov on 16 Jan 2017

I have tried all the above suggestions and have been able to building in release and debug mode. My issue is my staging build config in Xcode, it still complains about React/RCTBridge.h not found. My staging build configuration is a copy of production. I am not sure if this is a code push issue or a react native/my setup issue. I am just confused as to why release mode works but not staging when its just a copy of release. Any thoughts would be much appreciated. P.S. Staging build config worked before updating to react 0.40 from 0.38.

I have a stack overflow question with more details if you have any insight.

ezyone123 on 16 Jan 2017

👍3

@sergey-akhalkov thanks ,build success...

JusticeLai on 18 Jan 2017

@ezyone123
in case it may help for build process:
add
$(BUILD_DIR)/Release$(EFFECTIVE_PLATFORM_NAME)/include
to Xcode Build Settings / HEADER_SEARCH_PATHS

slicejunk on 19 Jan 2017

@chirag04 @stirman @JusticeLai @ezyone123
We've merged all of the required fixes and verified everything. [email protected] has been published to npm with support for [email protected]. Thanks for your patience.