React-native-code-push: AsyncStorage(get/set...) operation will be blocked while downloading the bundle

[dentalulcer]

Thanks so much for filing an issue or feature request! Please fill out the following (wherever relevant):

• react-native-code-push version: 1.12.1-beta
• react-native version: 0.25.1
• iOS/Android/Windows version: android 5.0.2(SAMSUNG Galaxy A3), android 6.0.1 MMB29M(MI MAX)
• Does this reproduce on a debug build or release build? both
• Does this reproduce on a simulator, or only on a physical device? both
• Repro steps and/or stack trace:

I store my login info locally using AsyncStorage, when I start my app and submit login info, the storage operation will be blocked while downloading the new codepush bundle, it happens on android. Is it normal?

Thanks for the amazing project!

[dentalulcer]

help

[jerson]

same here im using react-native-fs and block when download

[sopaco]

@dentalulcer @jerson
I also have some such problem only in Android.
see https://github.com/facebook/react-native/issues/10203

[dentalulcer]

it works for me
/** CodePushNativeModule.java->downloadUpdate() */ asyncTask.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);

[panarasi]

@sergey-akhalkov I think we should investigate this issue.

[jonrh]

I've been trying to diagnose a problem on an iOS app that may suffer from a similar trait. I'm using react-native-keychain to save/load passwords securely. I'm not entirely sure how it works but I think it's done asynchronously. Could there be a similar block/issue?

@buptkang: The v1.17.1-beta release notes states in Bug Fixes: "2. (Both iOS and Android) Fixed the issue #574". The pull request #693 only changed some Java files, were similar iOS changes made in a different PR/commit or was this perhaps never an issue on iOS?

[sergey-akhalkov]

@jonrh,

was this perhaps never an issue on iOS?

We've not reported before that the issue reproduces for iOS too, also @sopaco said:

I also have some such problem only in Android.

For the matter of that:

Could there be a similar block/issue?

I don't sure about it, so we need some investigation - could you please verify if the issue reproduces or not in case of using AsyncStorage (instead of using Keychain)? If so, please create new issue so we would able to start investigation and fixing.

[jonrh]

@sergey-akhalkov Thanks! I will try my best. It's been very hard though to produce code that reliably replicates this. I'll submit an issue if I'm able to. Thanks again for your hard work!

[sergey-akhalkov]

@jonrh, no problem, thank you!