React-native-code-push: [Android] buildConfigField saved in BuildConfig.java is not enclosed in quotes

Created on 22 Jun 2016  路  6Comments  路  Source: microsoft/react-native-code-push

I followed https://github.com/Microsoft/react-native-code-push#android;

It appears that the line
buildConfigField "String", "CODEPUSH_KEY", "EXAMPLE_STAGING_KEY" generates
public static final String CODEPUSH_KEY = EXAMPLE_STAGING_KEY in BuildConfig.java

When I run react-native run-android it gives an error pertaining to it (';' expected and expected)

react-native 0.24.0
react-native-code-push 1.12.2-beta

Most helpful comment

Got the same, the docs should state:

buildConfigField "String", "CODEPUSH_KEY", '"<INSERT_STAGING_KEY>"'

Note the single quotes outside the double. More info: http://stackoverflow.com/questions/30796533/how-to-generate-buildconfigfield-with-string-type

All 6 comments

@imalbert What version of RNPM are you running? The code you mentioned is actually generated by RNPM, not our plugin, so if there's a bug in it, I can follow up with them to get it looked at.

I'm using rnpm 1.9.0

Got the same, the docs should state:

buildConfigField "String", "CODEPUSH_KEY", '"<INSERT_STAGING_KEY>"'

Note the single quotes outside the double. More info: http://stackoverflow.com/questions/30796533/how-to-generate-buildconfigfield-with-string-type

Ah right, my bad. I just fixed this. Thanks so much for the feedback here!

This is awesome. Thanks guys!

why then applicationId "some string" - goes without double quotation ?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Adr1ann picture Adr1ann  路  3Comments

EdmundMai picture EdmundMai  路  4Comments

panarasi picture panarasi  路  4Comments

chrisjrex picture chrisjrex  路  4Comments

diegocouto picture diegocouto  路  4Comments