React-native-background-geolocation: stopOnTerminate name is misleading

[farshid1]

In the Doc, stopOnTerminate's note says "Set true to continue tracking after user terminates the app." This is misleading because if you set stopOnTerminate to true then the app shouldn't continue tracking after user terminates the app (logically speaking).

[christocracy]

Reported already from the Cordova folks. It's fixed on my local machine.

[farshid1]

Then just to double check, I have to set stopOnTerminate to true if I want the location to be tracked even when the user terminates the app?

• React Native version (react-native -v): 0.42.0
• Plugin version: 2.6.1

[christocracy]

No.

• If you want the plugin to "stop on terminate", you would say true.
• If you do NOT want the plugin to "stop on terminate", you would say false.

It's perfectly logical. There is no ambiguity in the naming of this param.

[farshid1]

You are right. I guess you and I are looking at this from different ends. It is perfectly logical until the doc throws you off.

[christocracy]

When in doubt, read the config params like a sentence. The docs were

recently had a significant refactor. There are a few bugs.

Snet form Gmail Mobile