React-native-app-auth: Callbacks do not work in iOS 10 and below following instructions in readme

[sattaman]

Issue

After testing I noticed the callbacks were not being handled correctly on ios10 and below, looking at the example project provided it looks like the instructions are incomplete. I've added the snippet in the linked PR and this seems to fix.

Environment

• Your Identity Provider: e.g. IdentityServer 4 / Okta / Azure
• Platform that you're experiencing the issue on: iOS / Android / both
• Are you using Expo?

[matt-way]

This undoes the information from: https://github.com/FormidableLabs/react-native-app-auth/issues/314

How do you combine the code in this PR with the react-native deep linking code requirements?

[sattaman]

I've got

• (BOOL)application:(UIApplication *)app openURL:(NSURL *)url
  options:(NSDictionary *)options {
  if ([self.authorizationFlowManagerDelegate
  resumeExternalUserAgentFlowWithURL:url]) {
  return YES;
  }
  return [RCTLinkingManager application:app openURL:url options:options];
  }

On Thu, Sep 12, 2019 at 6:43 AM Matt Way [e-mail] wrote:

This undoes the information from: #314
https://github.com/FormidableLabs/react-native-app-auth/issues/314

How do you combine the code in this PR with the react-native deep linking
code requirements?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FormidableLabs/react-native-app-auth/issues/342?email_source=notifications&email_token=AAJECX3X234IMQFVG5P4LJLQJHJHXA5CNFSM4H5DCEJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6QXEAQ#issuecomment-530674178,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJECX44WMRFXZY74NLOYOLQJHJHXANCNFSM4H5DCEJQ
.

[matt-way]

Thank you.