React-native-admob: RNAdMobRewardedVideoAdModule is not abstract and does not override abstract method onRewardedVideoCompleted() in RewardedVideoAdListener

Created on 30 May 2018  Â·  32Comments  Â·  Source: sbugert/react-native-admob

../node_modules/react-native-admob/android/src/main/java/com/sbugert/rnadmob/RNAdMobRewardedVideoAdModule.java:25: error: RNAdMobRewardedVideoAdModule is not abstract and does not override abstract method onRewardedVideoCompleted() in RewardedVideoAdListener
public class RNAdMobRewardedVideoAdModule extends ReactContextBaseJavaModule implements RewardedVideoAdListener {
^

Most helpful comment

Some versions (don't ask which one) of com.google.android.gms.ads.reward.RewardedVideoAdListener requires onRewardedVideoCompleted function. RNAdMobRewardedVideoAdModule class implements that class.

If you don't want to manage gms versions you can just create an empty function. I can't find any javascript call to that method anyway.

RNAdMobRewardedVideoAdModule.java

    @Override
    public void onRewardedVideoCompleted(){

    }

If your version of react-native-admob has onRewardedVideoCompleted function and you are getting 'method doesnt override' error, then remove the @Override annotation from method.

All 32 comments

+1

This has been fixed already in https://github.com/sbugert/react-native-admob/pull/273 . Are you using the latest version of this library?

I am using 1.3.2 @koenpunt , actually we do not wanna update version due to certain reason, how to handle this issue.

Oh I see.
// @Override Deprecated
public void onRewardedVideoCompleted() {
sendEvent(EVENT_VIDEO_COMPLETED, null);
}

I'm encountering this issue, installing directly from npm, following the installation instructions exactly.
What can I do to fix this?

Here are my logs:
$ react-native run-android

> Task :react-native-admob:compileDebugJavaWithJavac FAILED
/home/will/Documents/ReactNative/VideoToolkit/New/GIFit/node_modules/react-native-admob/android/src/main/java/com/sbugert/rnadmob/RNAdMobRewardedVideoAdModule.java:20: error: RNAdMobRewardedVideoAdModule is not abstract and does not override abstract method onRewardedVideoCompleted() in RewardedVideoAdListener
public class RNAdMobRewardedVideoAdModule extends ReactContextBaseJavaModule implements RewardedVideoAdListener {
       ^
1 error


FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-admob:compileDebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

I should mention:

Ubuntu 18.10
react-native-cli: 2.0.1
react-native: 0.57.8

Thank you for all the hard work you've done, I really appreciate it <3.

@wbrickner same issue here! have you fixed it?? Anyone please help

same problem

same problem

same problem

same problem

+1

I'm having the same issue.
RewardedVideoAdModule is not abstract and does not override abstract method onRewardedVideoCompleted() in RewardedVideoAdListener
react-native v0.58.4, react-native-admob v1.3.2

+1
exact same problem

+1

+1

Hello , haivng the issue , please help me
RewardedVideoAdModule is not abstract and does not override abstract method onRewardedVideoCompleted() in RewardedVideoAdListener
react-native v0.58.6, react-native-admob v1.3.2

hi guys,

if you install the latest version (v2.0.0-beta5) than the bug is gone.

ok thanks let me try then

On Saturday, 2 March, 2019, 12:16:49 pm IST, Arton Berisha <[email protected]> wrote:

hi guys,

if you install the latest version (v2.0.0-beta5) than the bug is gone.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

I have tried v2.0.0-beta5
on react-native-cli: 2.0.1 / react-native: 0.58.6

But it makes "application has stopped"

@kaiserleka have you looked at the emulator/device logs? maybe the application-id is wrong or missing?

@kaiserleka . i was also getting that same issue. but my issue is fixed after i added below statement in
android\app\build.gradle file
dependencies {
......
compile 'com.google.android.gms:play-services-ads:15.0.0'
implementation project(':react-native-admob')
...
}

This has been fixed already in #273 . Are you using the latest version of this library?

Thanks man, this saved me hours,

This has been fixed already in #273 . Are you using the latest version of this library?

Thanks man, this saved me hours,

That PR resolve this problem but it create new one => stop application

I have tried v2.0.0-beta5
on react-native-cli: 2.0.1 / react-native: 0.58.6

But it makes "application has stopped"

implementation ('com.google.android.gms:play-services-ads:16.+') { force = true; }

put in android/app/build.gradle
its work for me i am using react-native 0.16.4

Some versions (don't ask which one) of com.google.android.gms.ads.reward.RewardedVideoAdListener requires onRewardedVideoCompleted function. RNAdMobRewardedVideoAdModule class implements that class.

If you don't want to manage gms versions you can just create an empty function. I can't find any javascript call to that method anyway.

RNAdMobRewardedVideoAdModule.java

    @Override
    public void onRewardedVideoCompleted(){

    }

If your version of react-native-admob has onRewardedVideoCompleted function and you are getting 'method doesnt override' error, then remove the @Override annotation from method.

@Override
public void onRewardedVideoCompleted(){

}

It Worked but Now the App is Crashed...

Hi @Sanan4li please add this ------=>

<meta-data
            android:name="com.google.android.gms.ads.APPLICATION_ID"
            android:value="ca-app-pub-xxxxxxxxxxxxxxxx~yyyyyyyyyy"/>

into android AndroidManifest.xml
you can find AndroidManifest.xml from your_project_name/android/app/src/main

For more information you can visit official link https://developers.google.com/admob/android/quick-start

Hi @Sanan4li please add this ------=>

<meta-data
            android:name="com.google.android.gms.ads.APPLICATION_ID"
            android:value="ca-app-pub-xxxxxxxxxxxxxxxx~yyyyyyyyyy"/>

into android AndroidManifest.xml
you can find AndroidManifest.xml from your_project_name/android/app/src/main

Thanks... it worked but having another issue... I think it will be fixed... Thanks a lot.

can you send me AndroidManifest.xml code

can you send me AndroidManifest.xml code

I updated the comment.. after reinstalling the app it worked..

Hi @Sanan4li please add this ------=>

<meta-data
            android:name="com.google.android.gms.ads.APPLICATION_ID"
            android:value="ca-app-pub-xxxxxxxxxxxxxxxx~yyyyyyyyyy"/>

into android AndroidManifest.xml
you can find AndroidManifest.xml from your_project_name/android/app/src/main

Thanks... it worked but having another issue... I think it will be fixed... Thanks a lot.

Great

Hi @Sanan4li please add this ------=>

<meta-data
            android:name="com.google.android.gms.ads.APPLICATION_ID"
            android:value="ca-app-pub-xxxxxxxxxxxxxxxx~yyyyyyyyyy"/>

into android AndroidManifest.xml
you can find AndroidManifest.xml from your_project_name/android/app/src/main

Thanks... it worked but having another issue... I think it will be fixed... Thanks a lot.

Great

Was this page helpful?
0 / 5 - 0 ratings