React-modal: Remove usages of unsafe lifecycle methods

Created on 30 Mar 2018  路  4Comments  路  Source: reactjs/react-modal

React team recently published a blogpost: https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

TL;DR: cWM, cWRP, and cWU methods are considered unsafe for future async rendering and will be deprecated soon. The recommended way for open source maintainers to deal with it is to use react-lifecycles-compat package and migrate to new static getDerivedStateToProps method

feature react
Source
picture Hypnosphi
👍1

Most helpful comment

@Hypnosphi @diasbruno can I take this up? I am guessing this involves polyfilling the components so that they can be used with the current react version?

picture kaushik94 on 31 Mar 2018
👍3

All 4 comments

@Hypnosphi @diasbruno can I take this up? I am guessing this involves polyfilling the components so that they can be used with the current react version?

kaushik94 picture kaushik94 on 31 Mar 2018
👍3

Sure, @kaushik94. Follow the react-lifecycles-compat guide and everything should be fine.

diasbruno picture diasbruno on 31 Mar 2018

https://github.com/reactjs/react-modal/pull/639#discussion_r179925995

Hypnosphi picture Hypnosphi on 7 Apr 2018

Plus ModalPortal still uses cWRP: https://github.com/reactjs/react-modal/blob/master/src/components/ModalPortal.js#L79

Hypnosphi picture Hypnosphi on 9 Apr 2018
Was this page helpful?
0 / 5 - 0 ratings

Related issues

jrock17 picture jrock17  路  4Comments
leoasis picture leoasis  路  4Comments
c0debreaker picture c0debreaker  路  4Comments
yaoyao1024 picture yaoyao1024  路  3Comments
dragonball9816 picture dragonball9816  路  3Comments