React-modal: beforeClose Class is not working
Summary:
When i close the modal, it isn't changing the _afterOpen_ class instead of the _beforeOpen_ class. In react dev tools i can change the beforeOpen state, and so it finally works, but when i'm closing the modal either clicking escape or clicking in the close button or on the overlay area it isn't work.
fchubu
All 6 comments
thanks for the report. are you able to reproduce this bug in codepen so we can investigate?
sw-yx
on 27 Oct 2017
@sw-yx Yeah, sure!
fchubu
on 27 Oct 2017
hi @sw-yx, here is an example: https://codesandbox.io/s/k3jpyn9x5o.
If you look the modal when it is opening, you can see the css effects, but when you close it, the css classes are not working.
fchubu
on 27 Oct 2017
@facuch19 when using animations to close the modal use closeTimeoutMS={n}. If it is not defined the modal closes immediately.
diasbruno
on 27 Oct 2017
@diasbruno OMG bro, i was using closeTimeoutMS={n}. But i was using it with seconds.... closeTimeoutMS={2}, and it works with ms closeTimeoutMS={2000}. Now it艣 working perfectly.Anyway is good know it. Thanks you very much for the time.
fchubu
on 27 Oct 2017
Awesome.
...and thanks @sw-yx for taking the lead and start investigating the issue.
diasbruno
on 27 Oct 2017
Related issues
davidmfoley
路
3Comments
c0debreaker
路
4Comments
ChristopherVH
路
3Comments
CXJoyce
路
4Comments
emwee
路
4Comments
Most helpful comment
@diasbruno OMG bro, i was using
closeTimeoutMS={n}. But i was using it with seconds....closeTimeoutMS={2}, and it works with mscloseTimeoutMS={2000}. Now it艣 working perfectly.Anyway is good know it. Thanks you very much for the time.