React-modal: Please remove unused dependency react-dom-factories

Created on 28 Sep 2017  路  4Comments  路  Source: reactjs/react-modal

Summary:

react-dom-factories was used in lib/components/Modal.js but removed in conversion to ES2015 src/components/Modal.js.

Steps to reproduce:

  1. Search repo for react-dom-factories
  2. See it is not used by any source files.

Expected behavior:

Should not be installed.

Additional notes:

I realise this dependency is not imported and so is not in dist build or my app's bundle. I wondered why it was in my apps node_modules and saw the repos readme says it should not be used and wondered why react-modal was depending on it to find out it no longer uses it.

dependencies

Most helpful comment

Thanks!

All 4 comments

Hi @bjbrewster, just give a thumbs up and I'll merge (I couldn't assign you on the PR).

Thanks!

Thanks for fixing this @diasbruno ! Any ideas when the next npm release for react-modal is planned?

Released v2.3.3. Sorry for taking so long.

Was this page helpful?
0 / 5 - 0 ratings