React-modal: React v16-beta upgrade - componentWillUnmount error

[jakepeyser]

Summary:

The Modal component is throwing an error in componentWillUnmount after upgrading React to v16-beta.

Steps to reproduce:

1. Upgrade React to @next
2. Use the Modal component as before.
3. Remove the containing component from the DOM and the error will occur

Additional notes:

After some research, it seems this is directly related to the usage of renderSubtreeIntoContainer method to set this.portal in Modal. This is described in depth in https://github.com/facebook/react/issues/10309. Since portal is never set correctly, assuming its existence in componentWillUnmount causes the error.

Details

• Mac OSX
• Chrome v59.0.3071.115

[diasbruno]

Hi @jakepeyser #474 is available. A new version will be available today.

[jakepeyser]

Brilliant. Thanks @diasbruno

[diasbruno]

Released v2.2.3.

[uwolfer]

In my case, ReactModalPortal DOM elements are leaked due to this. When this.portal is undefined, things do not get cleaned up. This can be reproduced in my case with React 16 only - it works fine with React 15.x. Can you please check your DOM and see if things get cleaned up?

[diasbruno]

@uwolfer [email protected] is available now. Let me know if this still happens.

To install, use npm install react-modal@next.

[uwolfer]

@diasbruno: Thank you, this fixes my issue.