React-modal: Body ClassName not available

Created on 26 May 2017  路  7Comments  路  Source: reactjs/react-modal

Summary:

The bodyOpenClassName prop is not being used in the last tag provided by this module. However, this feature is currently implemented on master branch of the repository. It would be important to create a new TAG with this feature.

Steps to reproduce:

  1. Render a Modal with the bodyOpenClassName prop on it.

Expected behavior:

New class should be added to the body instead of the default ReactModal__Body--open

Additional notes:

This commit also contains the object classNames which would solve Issue #385

documentation feature

Most helpful comment

@tiagojsalmeida @vasco-santos can you review PR #404?

All 7 comments

Yeah, this feature needs a backport tov1.

When is this going to be released?

@tiagojsalmeida or @vasco-santos do you mind take care of this backport? I'm trying to do some house cleaning on react-modal.

@tiagojsalmeida @vasco-santos can you review PR #404?

Thanks for the backport.

I reviewed the code, and it seems ready for being launched. 馃槃

Released v1.8.1.

Since, bodyOpenClassName is now available on v1.8+, I'm close this issue.
Thank you, @vasco-santos.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

gavmck picture gavmck  路  3Comments

claydiffrient picture claydiffrient  路  4Comments

fabien-somnier picture fabien-somnier  路  3Comments

dragonball9816 picture dragonball9816  路  3Comments

davidmfoley picture davidmfoley  路  3Comments