React-modal: Latest release doesn't work on UglifyJs

[3LOK]

Summary:

You've released a new version of react-modal a couple of hours ago.

As you can see here, you forgot a 'function' keyword for non ES6 class component, and UglifyJs doesn't like this a single bit...

(see definition of removePortal with missing function compared to reset of the functions there).

Steps to reproduce:

1. Try to uglifyjs this project.

Expected behavior:

For UglifyJs to succeed. It now doesn't.

Additional notes:

Thanks!!!

[gengjiawen]

And this line in ModalPortal.js too.

[damtur]

Can you please fix this ASAP? This is breaking tones of our builds unfortunately. Can you provide ETA and let me know please? Thank you!
CC: @diasbruno @claydiffrient

Update. I see https://github.com/reactjs/react-modal/pull/337 so I'm quite relaxed now. Thank you for doing that! 🎩

[diasbruno]

Backporting problems.
It happens sometimes. :)

[glitch100]

@diasbruno Do we have a high level ETA on the fix branch going out?

[bencrinkle]

having the same issue as we use react-bootstrap-table which has react-modal as a dependancy. Have had to manually add react-modal and hardcode the version to 1.6.5 to get the build to work.

[diasbruno]

v1.7.1 was released.

[nancruz]

v1.7.1 fixed the problem

[claydiffrient]

Going ahead and closing this since 1.7.1 has been reported to have indeed fixed the problem.