React-map-gl: Towards typescript?

Created on 10 Aug 2020  路  6Comments  路  Source: visgl/react-map-gl

Given rest of visgl suite is moving towards typescript, consider either:

  • Adding separate .d.ts type files for typescript and keep flow in the code.
  • migrate code from flow to typescript (nebula.gl "automated" this using a conversion tool).

Most helpful comment

It may be possible that I can do a PR for a conversion to typescript late January

All 6 comments

nebula.gl did an automated conversion from flow to typescript, it is quite well explained in https://github.com/uber/nebula.gl/pull/377

CC @supersonicclay @kikonejacob are you react-map-gl users? Any chance of getting help, perhaps a partial PR, for react-map-gl based on the same recipe you used for nebula.gl?

If the auto conversion doesn't work as desired, I'd be happy to help with writing the declarations by hand.

It may be possible that I can do a PR for a conversion to typescript late January

@mayteio @kikonejacob Much appreciated! I plan to make an initial PR by the end of this week to set up the dev tools and dependencies for TypeScript development. We can definitely use some help authoring and testing the types after that!

@mayteio @kikonejacob Just published 6.1.0-alpha.1 that includes both TypeScript and Flow typings. Would appreciate if you give it a try and report any issues!

TypeScript typings will be available in v5.3/v6.1.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

cjmyles picture cjmyles  路  3Comments

miccferr picture miccferr  路  4Comments

AriLFrankel picture AriLFrankel  路  3Comments

tomrussell picture tomrussell  路  5Comments

xoddong picture xoddong  路  4Comments