React-jsonschema-form: ANNOUNCEMENT: Breaking changes planned for v3

Created on 22 Mar 2021  路  10Comments  路  Source: rjsf-team/react-jsonschema-form

The next version of rjsf will be v3, and we'll add a few breaking changes to it.

Planned changes

PRs that are nearly ready and will be added in v3:

  • [ ] refactor: types for withTheme #2279
  • [x] No core-js in core #2211
  • [x] Drop support for node 8 / 9 #2031
  • [x] Drop support for node 10 #2299
  • [ ] Maintain AJV properties when custom validator is in use. #2002

Other potential changes

If someone makes PRs for these issues, we might be able to get them into v3.

  • noHtml5Validate should be true by default #1184
  • Fieldset preventing flexbox styling #762

These PRs would be good to add, but still have some work to do on them:

Have suggestions for changes / additional items we should add to this list? Feedback welcome!

cc @ri0ter @erunion @stanlemon @mattcosta7 @zepatrik @wegry @jimmycallin @robophred @bmmpt

announcement

Most helpful comment

@epicfaace You also mentioned this old PR of mine to be a breaking change https://github.com/rjsf-team/react-jsonschema-form/pull/1522

might be time to merge it then (or let me know if you want me to revert the breaking change part). personally i would love to see rjsf to be strict mode valid as a part of v3.

All 10 comments

@epicfaace I was hoping the react-is bump might make it into v3 as well. https://github.com/rjsf-team/react-jsonschema-form/pull/2196.

Oh, is that a breaking change? If not, we can still get it in either in v3 or sometime later, but the scope of this issue is just categorizing the breaking changes (because they _have_ to be released on a new major bump).

Sounds good.

Is that a breaking change?

I don't believe so. Just something I've been hankering for.

@epicfaace sounds good to me.

I noticed there's a few things tagged with 'deprecated' in the codebase. might be a good time to clean those as well.

Particularly

  • autocomplete vs autoComplete
  • ui:widget object API, where a widget and options were specified with "ui:widget": {component, options} shape

Sounds good! Might want to look into the discussions in this PR and consider them as well https://github.com/rjsf-team/react-jsonschema-form/pull/2010

Some thoughts...

  • Previously we discussed swapping out native controls in the Material UI theme for their provided ones, specifically the date picker.
  • Any widget built around arrays and nesting requires a lot of work in a new theme, it would be great if to make that a lighter lift.
  • This might be controversial, but perhaps we drop the verbose date picker with tons of selects altogether.

@epicfaace You also mentioned this old PR of mine to be a breaking change https://github.com/rjsf-team/react-jsonschema-form/pull/1522

might be time to merge it then (or let me know if you want me to revert the breaking change part). personally i would love to see rjsf to be strict mode valid as a part of v3.

@gsstar9028 no worries, it's already been merged into master, so it will be included!

personally i would love to see rjsf to be strict mode valid as a part of v3.

@jimmycallin Agreed, that would be nice! (so we'd need to stop using unsafe component lifecycle methods) Sorry for the delay in responding to your other PR.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

FBurner picture FBurner  路  3Comments

norim13 picture norim13  路  3Comments

Eric24 picture Eric24  路  3Comments

marinav picture marinav  路  3Comments

anttivikman picture anttivikman  路  3Comments