React-jsonschema-form: type is undefined but have allOf

[joneldiablo]

Hi, I have a very long jsonschema which I want see as form.
Using the live demo, have this error:

doing some test using the live demo, I found that if type is not declared, throw the error, its possible use allOf without type?

[epicfaace]

@joneldiablo
Can you please send a playground link demonstrating this issue? https://mozilla-services.github.io/react-jsonschema-form/

[joneldiablo]

simplified:
https://mozilla-services.github.io/react-jsonschema-form/#eyJmb3JtRGF0YSI6eyJuZXdSZWxlYXNlTWVzc2FnZSI6NX0sInNjaGVtYSI6eyJ0aXRsZSI6IkNyZWF0ZSBuZXcgcmVsZWFzZSBtZXNzYWdlIiwiZGVzY3JpcHRpb24iOiJkZGV4IHYzLjguMiIsInR5cGUiOiJvYmplY3QiLCJwcm9wZXJ0aWVzIjp7Im5ld1JlbGVhc2VNZXNzYWdlIjp7ImFsbE9mIjpbeyJ0eXBlIjoibnVtYmVyIn0seyJ0eXBlIjoiaW50ZWdlciJ9XX19fSwidWlTY2hlbWEiOnt9fQ==

[travisdahl]

running into the same problem, it looks like allOf isnt supported yet...
https://github.com/mozilla-services/react-jsonschema-form/issues/52

[joneldiablo]

checking anyOf and allOf, the same error is thrown when _type_ its not declared in the property element, I think the solution is take the _type_ from the $ref or from the object in array anyOf or allOf to validate the type. check this other example:
https://mozilla-services.github.io/react-jsonschema-form/#eyJmb3JtRGF0YSI6eyJuZXdSZWxlYXNlTWVzc2FnZSI6e319LCJzY2hlbWEiOnsidGl0bGUiOiJDcmVhdGUgbmV3IHJlbGVhc2UgbWVzc2FnZSIsImRlc2NyaXB0aW9uIjoiZGRleCB2My44LjIiLCJ0eXBlIjoib2JqZWN0IiwicHJvcGVydGllcyI6eyJuZXdSZWxlYXNlTWVzc2FnZSI6eyJhbnlPZiI6W3siJHJlZiI6IiMvZGVmaW5pdGlvbnMvYSJ9LHsiJHJlZiI6IiMvZGVmaW5pdGlvbnMvYiJ9XX19LCJkZWZpbml0aW9ucyI6eyJhIjp7InRpdGxlIjoidGhlIEEgb3B0IiwidHlwZSI6InN0cmluZyJ9LCJiIjp7InRpdGxlIjoidGhlIEIgb3B0IiwidHlwZSI6Im9iamVjdCIsInByb3BlcnRpZXMiOnsieSI6eyJ0aXRsZSI6InRoZSBZIiwidHlwZSI6InN0cmluZyJ9fX19fSwidWlTY2hlbWEiOnt9fQ==

[travisdahl]

simplified:
https://mozilla-services.github.io/react-jsonschema-form/#eyJmb3JtRGF0YSI6eyJuZXdSZWxlYXNlTWVzc2FnZSI6NX0sInNjaGVtYSI6eyJ0aXRsZSI6IkNyZWF0ZSBuZXcgcmVsZWFzZSBtZXNzYWdlIiwiZGVzY3JpcHRpb24iOiJkZGV4IHYzLjguMiIsInR5cGUiOiJvYmplY3QiLCJwcm9wZXJ0aWVzIjp7Im5ld1JlbGVhc2VNZXNzYWdlIjp7ImFsbE9mIjpbeyJ0eXBlIjoibnVtYmVyIn0seyJ0eXBlIjoiaW50ZWdlciJ9XX19fSwidWlTY2hlbWEiOnt9fQ==

not sure what you expected in the first allOf example. Why would you create something and define 2 different types? or are you just expecting it to cascade and use the last type defined?

In any case allOf doest work even if you have only a single type defined....

https://mozilla-services.github.io/react-jsonschema-form/#eyJmb3JtRGF0YSI6eyJuZXdSZWxlYXNlTWVzc2FnZSI6NX0sInNjaGVtYSI6eyJ0aXRsZSI6IkNyZWF0ZSBuZXcgcmVsZWFzZSBtZXNzYWdlIiwiZGVzY3JpcHRpb24iOiJkZGV4IHYzLjguMiIsInR5cGUiOiJvYmplY3QiLCJwcm9wZXJ0aWVzIjp7Im5ld1JlbGVhc2VNZXNzYWdlIjp7ImFsbE9mIjpbeyJ0eXBlIjoibnVtYmVyIn1dfX19LCJ1aVNjaGVtYSI6e319

[travisdahl]

I was able to work around the current limitations with a couple extra libraries.First I resolve all the refs then I merge all the allOf...

import deref from 'json-schema-deref-sync';
import mergeAllOf from 'json-schema-merge-allof';
const schema = {...}
...
const resolvedSchema = deref(schema);
const mergedSchema = mergeAllOf(resolvedSchema);
export default mergedSchema;

not ideal, but could get you by in a pinch and easy enough to remove once these issues are resolved.