React-joyride: Update @types/react-joyride package for the new version

Created on 30 May 2018  路  9Comments  路  Source: gilbarbara/react-joyride

Expected behavior

Current version of the @types/react-joyride is 1.10.2 which doesn't match the properties of the latest version of the library.

Actual behavior

Spits out properties errors like Property X does not exist...

Steps to reproduce the problem

Run Joyride with typescript

React version

16.3.2 + typescript 2.8.3

React-Joyride version

2.0.0-11

Error stack

Example:
TS2339: Property 'continuous' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Joyride> & Readonly<{ children?: ReactNode; }> & R...'.

V2 help wanted

Most helpful comment

All 9 comments

Any progress on this?

This is not published by this package.

Hi @gilbarbara
Can you point out or help with which package / repo / team should this be addressed?

@prawn-cake I resolved this by uninstalling @types/react-joyride and creating a custom type declaration in @types/react-joyride/index.d.ts here's a gist.

Thanks @wlindner.
It would be nice to have official solution though to avoid too many customisations.

@gilbarbara can you take a look at @wlindner solution and may be push it forward if it's sufficient?

@prawn-cake It doesn't look right. I don't expose any methods in V2

I'll try to add an official package before the final release.
If somebody wants to help, that would be great.

@gilbarbara I can help. What do you exactly want me to help with?
To write type definitions for the public interface of the library?
Do you have any preferences of the contribution process?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

BlockChange picture BlockChange  路  5Comments

msalsas picture msalsas  路  3Comments

kAleksei picture kAleksei  路  5Comments

snlhnk picture snlhnk  路  5Comments

rlajous picture rlajous  路  3Comments