React-i18next: Razzle-SSR example broken since 8.1.1

[krazyjakee]

Describe the bug
Razzle-SSR example broken since 8.1.1.
https://github.com/i18next/react-i18next/tree/master/example/razzle-ssr

Occurs in react-i18next version
v8.1.1

To Reproduce
Steps to reproduce the behavior:

1. Clone example.
2. Add a second route
3. Click on NavLink from react-router-dom
4. URL changes, but the application doesn't rerender

Expected behaviour
Load the next page

[jamuhl]

guess caused by https://github.com/i18next/react-i18next/commit/686c47898bef5a526dd85bb77dc8740f06894357#diff-e4eda667c493b066ae0e390d2ca16e52

hm...might consider rollback - or update the sample at some point. for now downgrading react-i18next to v6.x.x should make it work again.

[jamuhl]

@a-barbieri could this be related to your PR?

[a-barbieri]

I'm not sure, but I don't understand which is the faulty link. In the example there are just external links, am I wrong?

https://github.com/i18next/react-i18next/blob/master/example/razzle-ssr/src/Home.js#L23-L31

[jamuhl]

@kadishmal did you meant those external links? Guess yes, as there are no others. Sorry, @a-barbieri should have seen that myself...those are just links to external information no links to second page.

[krazyjakee]

Damn, I see I missed that in the issue. I will update it.

That example needs a secondary route. Essentially the router is broken there when adding a second route.

When I find time, I will update the example with a second route to make it a recreation of the issue without modification.

[Dakkers]

so... what's the actual fix for this?

[jamuhl]

please start adding changes related to the v9 version to the v9.x.x branch (master will be now for the upcoming v10 hooks)

--> https://github.com/i18next/react-i18next/tree/v9.x.x

[jamuhl]

closing for now...won't invest time in the v9 samples....hopefully we get a v10 sample up again at some point