React-grid-layout: Drag from outside is missing placeholder

Created on 27 Feb 2020  路  9Comments  路  Source: STRML/react-grid-layout

Run /examples/15-drag-from-outside.html using version 0.18.x and note that the placeholder doesn't show up at all like it does in v0.17: https://strml.github.io/react-grid-layout/examples/15-drag-from-outside.html

All 9 comments

I'm also experiencing this problem.

me too
Duplicate of #1153

me too

I have the same issue. This also means that the rest of the layout doesn't shift in response to dragging it over items.

Also running into this, it seems to me that this line should trigger an update to state (probably activeDrag or something like it) but instead, it just modifies a local variable, which doesn't trigger any render. I might dig in later to try to understand what the appropriate response should be, if i get some time.

I would assume these changes are due to the performance improvements in 0.18, so I'd like to figure out a way to maintain performance but also get the placeholder working.

I've submitted a PR to fix this. @STRML let me know if there are any changes needed, I know this issue is blocking me from using this library entirely.

@STRML any idea when this might be released? Just want to know if I should fall back to 0.17 or wait for the newest 0.18.

Good call. Released 0.18.3

Was this page helpful?
0 / 5 - 0 ratings

Related issues

derisen picture derisen  路  3Comments

fsalamida picture fsalamida  路  3Comments

victor-unsw picture victor-unsw  路  3Comments

dphaener picture dphaener  路  3Comments

Francismb picture Francismb  路  4Comments