React-fontawesome: typescript icon names missing?

Created on 22 Feb 2018  路  12Comments  路  Source: FortAwesome/react-fontawesome

I am using @fortawesome/react-fontawesome": "0.1.0-3", the IconName type seems to be missing a few like repeat, rectangle-portrait, for example are both missing.

Are there plans to add all the icons? Or is a PR needed?

~S

bug

All 12 comments

Sure enough @sheam. We'll take a look.

FYI: fal, sign-in missing too.

Note for others who find this, the workaround is to cast to _any_: <FontAwesomeIcon icon={['fal', 'sign-in' as any]} />

This should be all fixed up in @fortawesome/[email protected] and @fortawesome/[email protected]

My package.json currently has these lines:

    "@fortawesome/fontawesome": "^1.2.0-2",
    "@fortawesome/react-fontawesome": "0.1.0-3",

which already seems to be ahead of what you are proposing.... I do not have fontawesome-common-types0.1.3, maybe that is my problem?

If I change my package.json and remove the lines I have with outs, the FontAwesomeIcon component no longer exists.

It's gonna be in the fontawesome-common-types package. Can you try that?

the following seems to work:

image

Did you have this issue with brand icons? I am using your same setup with TypeScript and it cannot find "fort-awesome" as an icon.

Could not find icon {prefix: "fas", iconName: "fort-awesome"}

The prefix will be fab for the Brands style @SomethingSexy

Hmm, so this is what I am doing:

import '@fortawesome/fontawesome-free-brands';
import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';

<FontAwesomeIcon icon="fort-awesome" />

Bundling via webpack. It seems to be working for free solid icons.

<FontAwesomeIcon icon={["fab", "fort-awesome"]}/>

Damn, I totally missed that. Thanks!

color?: string; is missing from index.d.ts in the dev branch. I forked and added it:

https://github.com/kirkbross/react-fontawesome/blob/f-kirkbross-color-prop/index.d.ts

Was this page helpful?
0 / 5 - 0 ratings

Related issues

gtkatakura-bysoft picture gtkatakura-bysoft  路  5Comments

henfreire picture henfreire  路  5Comments

lomse picture lomse  路  5Comments

johnnunns picture johnnunns  路  6Comments

pierreferry picture pierreferry  路  5Comments