React-final-form: Form can still be submitted even with validation errors

Created on 1 Dec 2017  ·  6Comments  ·  Source: final-form/react-final-form

Hey, https://github.com/erikras/react-final-form/issues/3 is still an issue.

I've updated the codesandbox demo to 1.1.0 and I can get all errors from the form, but I can still submit it.

Validation errors check should probably be added in hasSyncErrors here, but how's this test passing then.

Am I missing something? 🤔

Most helpful comment

That test was broken, as there was an invalid registered field. 🤦‍♂️

All 6 comments

Great reporting. Yep, that's a bug.

That test was broken, as there was an invalid registered field. 🤦‍♂️

Published fix in final-form v1.2.1.

@erikras yep, it's working now. Thank you! 🤗

Does final-form has analog of 'persistentSubmitErrors' like it was in redux-form ?
What if i validate fields in recommendation way, and anyway allow user to submit form?

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ThaNarie picture ThaNarie  ·  3Comments

niros-welldone picture niros-welldone  ·  3Comments

morloy picture morloy  ·  4Comments

mewben picture mewben  ·  3Comments

tpbowden picture tpbowden  ·  4Comments