React-diagrams: Can't resolve '@emotion/core' in 'react-canvas-core' / add to peerDeps?

Created on 8 Jan 2020  路  2Comments  路  Source: projectstorm/react-diagrams

Can't resolve @emotion/core' in '***\node_modules\@projectstorm\react-canvas-core\dist

should '@emotion/core' be added to the packages for react-canvas-core, or is there a reason for keeping it clean? I understand that devs may choose to use other ways of styling, but the package falls over without it.

https://github.com/projectstorm/react-diagrams/blob/469dbc00aff2161ef48da210649971deeec066d8/packages/react-canvas-core/package.json#L31-L38

related: https://github.com/projectstorm/react-diagrams/issues/438 https://github.com/projectstorm/react-diagrams/issues/460#issuecomment-549390814_

question

Most helpful comment

npm install
@emotion/core
@emotion/styled
dagre
mathjs
pathfinding
paths-js
resize-observer-polyfill
closest
lodash

386

All 2 comments

I think these dependencies should be added do peerDependencies indeed, and also the Getting Started section of the documentation should be updated.

npm install
@emotion/core
@emotion/styled
dagre
mathjs
pathfinding
paths-js
resize-observer-polyfill
closest
lodash

386

Was this page helpful?
0 / 5 - 0 ratings

Related issues

abhijitnandy2011 picture abhijitnandy2011  路  3Comments

ganesh-sankey picture ganesh-sankey  路  4Comments

t-gacema picture t-gacema  路  4Comments

shortwavedave picture shortwavedave  路  3Comments

DanieLazarLDAPPS picture DanieLazarLDAPPS  路  3Comments