React-devtools: Work with styled-components and Emotion authors/maintainers to get rid of <Context.Consumer>s

Created on 20 Jun 2019  Â·  6Comments  Â·  Source: facebook/react-devtools

DevTools is great, and I know this isn't your responsibility, but if you guys could sync up and help educate the authors/maintainers of styled-components and Emotion on a nice way to get rid of the million-billion <Context.Consumer>s that pollute DevTools I would be soooooo happy.

I _think_ styled-components may have already fixed this with their latest release, and I _think_ that Emotion is working on it, but I'm not sure if they got stuck somewhere.

Just opening this to try to promote collab/discussion between DevTools and these libs, as this <Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer>Hello World... stuff really ruins the DevTools experience and with how nice DevTools v4 is, I would hate for that pollution to stick around.

Most helpful comment

Correct, see the announcement blog post for an example

On Thu, Jun 20, 2019 at 5:07 PM Cory Simmons notifications@github.com
wrote:

@probablyup https://github.com/probablyup So DevTools isn't polluted
with any

stuff in v5?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-devtools/issues/1355?email_source=notifications&email_token=AAELFVTREYQUKSLG6D3IZOTP3P5RRA5CNFSM4HZ624FKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYG34PY#issuecomment-504217151,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAELFVV2VWC62A4GO56RNZ3P3P5RRANCNFSM4HZ624FA
.

All 6 comments

@probablyup @mitchellhamilton as the lead authors/maintainers of your projects, could you please let everyone know the current status of this <Context.Consumer> stuff? If it's fixed, what version? If it's in progress, what's left?

@corysimmons the styled-components v5 beta switched entirely over to the useContext hook, but we still ship the context consumer if people want to use it

@probablyup So DevTools isn't polluted with any <Context.Consumer><Context.Consumer><Context.Consumer><Context.Consumer> stuff in v5?

Correct, see the announcement blog post for an example

On Thu, Jun 20, 2019 at 5:07 PM Cory Simmons notifications@github.com
wrote:

@probablyup https://github.com/probablyup So DevTools isn't polluted
with any

stuff in v5?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-devtools/issues/1355?email_source=notifications&email_token=AAELFVTREYQUKSLG6D3IZOTP3P5RRA5CNFSM4HZ624FKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYG34PY#issuecomment-504217151,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAELFVV2VWC62A4GO56RNZ3P3P5RRANCNFSM4HZ624FA
.

React DevTools has been rewritten and recently launched a new version 4 UI. The source code for this rewrite was done in a separate repository and now lives in the main React repo (github.com/facebook/react).

Because version 4 was a total rewrite, and all issues in this repository are related to the old version 3 of the extension, I am closing all issues in this repository. If you can still reproduce this issue, or believe this feature request is still relevant, please open a new issue in the React repo: https://github.com/facebook/react/issues/new?labels=Component:%20Developer%20Tools

These new devtools are soooo good. Thanks to everyone involved in making it. 🙇

Was this page helpful?
0 / 5 - 0 ratings