React-dates: Shortcuts on singleDatePicker

[liormaynhypr]

hey,
i'm using singleDatePicker and i would like the shortcuts button to not be displayed.
how can i do that?
is there a prop i'm missing that disables the display of that button?

thanks :)

[sag1v]

was about to ask the same, the only condition i found for displaying that is !isTouch on the DayPicker.jsx:

would be nice if we can explicitly configure to hide / show this, for example via a prop enableKeyboardShortcuts

[ljharb]

Why would you want to hide it? It's for accessibility.

[liormaynhypr]

it overflowed and i don't have enough room in the page where the date picker is needed to adjust the sizes..

[liormaynhypr]

i fixed it with display none in the meantime but i think it would be nice if it was optional

[ljharb]

I think that perhaps what would make the most sense is an option to disable the keyboard shortcuts unconditionally, which would then naturally hide the shortcuts button.

[sag1v]

@ljharb what do you mean by

an option to disable the keyboard shortcuts unconditionally

do you mean that there shouldnt be an option to show / hide the shortcut but instead an option to disable the feature as a whole?

[ljharb]

Correct. If keyboard shortcuts work, the "?" button should be displayed; if it's not displayed, the shortcuts shouldn't work.

[sag1v]

I think the keyboard shortcuts feature should get some second attention. i mean it's a great feature but can't really use it with the issues it has. #461 #462

[kbariotis]

@ljharb specific users may not need accessibility (shortcuts specifically) and throwing to them an extra button will just confuse them more.

Having an option to disable shortcuts all together sounds good to me since if you don't know that shortcuts exist you wouldn't expect something to happen if you accidentally press a key.

Thank you :)

[sag1v]

issue #427 got most of the issues we mentioned the last couple of days regarding the keyboard shortcuts

[majapw]

@ljharb I disagree. Keyboard shortcuts should be non-negotiable, but I think it's fine to have an option to hide the menu.

[sag1v]

@majapw you mean hiding the button that shows the menu?

[majapw]

Yeah. I've added an option for that in https://github.com/airbnb/react-dates/pull/477

[ljharb]

@majapw why is it acceptable for keys to secretly trigger behavior without a clear explanation for what they do?

[majapw]

The hideKeyboardShortcutsPanel prop is available in the latest version.