React-dates: Month name not updating on language change
When I change my moment.locale() the days of the calendar update but month names don't unless I completely re-render my page. Is there something special about the way that calendar months are handled that I'm missing?
oldo
All 8 comments
It seems we should probably be caching and checking the moment locale in shouldComponentUpdate (and anything else stateful about the moment singleton) on all our components.
ljharb
on 12 Feb 2017
@oldo how do you change the moment.locale()?
I'm trying a way to do it as well, but I don't find how .-.
willianribeiro
on 8 Mar 2017
Hi @willianribeiro, have you looked at https://github.com/airbnb/react-dates/blob/master/stories/DateRangePicker.js#L67?
majapw
on 8 Mar 2017
Thank you @majapw, it is easier than I have thought (-;
willianribeiro
on 8 Mar 2017
If anyone is still struggling to get the month names to translate when switching back and forth between different locales, I came up with a workaround. Add the following as a prop to DateRangePicker:
// `language` being the desired locale
renderMonthElement={({ month }) => moment(month).locale(language).format('MMMM YYYY')}
The moment objects internal to the component don't seem to get updated when changing moment's locale (even a re-render doesn't fix it). Hope it helps!
ian-rudge
on 22 Aug 2018
Workaround from @ian-rudge works! 馃殌
But I am having same issue with month representation in the input. Any workaround for that?
matejstrasek
on 20 Nov 2018
a medal of honor to @ian-rudge
oneinchman
on 6 Dec 2018
@ian-rudge You are awesome
Thanks :)
GaneshSinghPapola
on 25 Feb 2021
Related issues
aaronvanston
路
3Comments
aishwarya-bote
路
3Comments
HartiganHM
路
3Comments
augnustin
路
3Comments
yokomizor
路
3Comments
Most helpful comment
If anyone is still struggling to get the month names to translate when switching back and forth between different locales, I came up with a workaround. Add the following as a prop to
DateRangePicker:The moment objects internal to the component don't seem to get updated when changing moment's locale (even a re-render doesn't fix it). Hope it helps!