React-datepicker: ReadOnly props is not working

Created on 25 Aug 2018 · 3Comments · Source: Hacker0x01/react-datepicker

Expected behavior

I added readOnly props to datePicker component but when I using this props, then the component is not working but if I remove it, it's working.
NOTE: This problem was not available before.

Actual behavior

I should be work with datePicker while it has readOnly props.

Steps to reproduce

wontfix

Source

ali-master

👍8

Most helpful comment

The change in #1419 broke us as well. I'm also in favor of reverting it. Until then, here is our workaround:

const ForceReadOnlyInput = React.forwardRef((props, ref) => (
  <input {...props} ref={ref} readOnly={true} />
));

<ReactDatePicker
  customInput={<ForceReadOnlyInput />}
/>

It would have been nice to just pass customInput={<input readOnly={true} />}, but the library overwrites the attribute during render.

whatisaphone on 31 Aug 2018

👍5 ❤3

All 3 comments

For some reason this was changed in https://github.com/Hacker0x01/react-datepicker/pull/1419

Here's the solution I came up with: https://github.com/Hacker0x01/react-datepicker/issues/1443#issuecomment-416531351

pniebrzydowski on 28 Aug 2018

The change in #1419 broke us as well. I'm also in favor of reverting it. Until then, here is our workaround:

const ForceReadOnlyInput = React.forwardRef((props, ref) => (
  <input {...props} ref={ref} readOnly={true} />
));

<ReactDatePicker
  customInput={<ForceReadOnlyInput />}
/>

It would have been nice to just pass customInput={<input readOnly={true} />}, but the library overwrites the attribute during render.

whatisaphone on 31 Aug 2018

👍5 ❤3

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.